-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync mtime with updated time #468
Conversation
@@ -254,6 +256,11 @@ def download_to_filename(self, filename): | |||
with open(filename, 'wb') as file_obj: | |||
self.download_to_file(file_obj) | |||
|
|||
mtime = time.mktime(datetime.datetime.strptime( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@grapefruit623 I think it's bad form to have 4 commits for such a small change; it certainly makes the history filled with noise. Would you mind re-writing the history in your branch? I'm happy to help if you're having issues. As for the change, it seems just fine but I don't feel like I understand reasons not to do this / behavior in other libraries like |
@grapefruit623 can you please sign the CLA, as described in CONTRIBUTING. |
e794ec4
to
c25a6e7
Compare
Hello, I modified my git commit to one commit so it look like clear. |
Thanks, LGTM. @silvolu, can you please confirm the CLA? |
CLA signed. |
We are good to merge this? |
Source-Link: googleapis/synthtool@5f2a608 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…e dump (#468) * feat: add support for new ImportEntries() API, including format of the dump feat: add support for entries associated with Looker and CloudSQL feat: add support for a ReconcileTags() API method PiperOrigin-RevId: 516484690 Source-Link: googleapis/googleapis@50eef0f Source-Link: googleapis/googleapis-gen@09b2058 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDliMjA1ODE5YWE2ZDgyMzkzZWY4NjViNTk2NTcxODE0YzVkMTg0MCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Delete sync-repo-settings to use the default required checks --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* chore: upgrade gapic-generator-java, gax-java and gapic-generator-python PiperOrigin-RevId: 423842556 Source-Link: googleapis/googleapis@a616ca0 Source-Link: googleapis/googleapis-gen@29b938c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjliOTM4YzU4YzFlNTFkMDE5ZjJlZTUzOWQ1NWRjMGEzYzg2YTkwNSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
Source-Link: googleapis/synthtool@c4dd595 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* chore(samples): deleting migrated samples * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
fix(deps): require proto-plus >= 1.22.0
Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790
For issue #311
storage.key.get_contents_to_filename will sync file's mtime and metadata's updated time