Moving will_accept() check out of PublisherClient.batch() factory.
#4613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first stage of moving that check directly into `Batch.publish()`. This check **must** occur when the message is being published because concurrent access to the messages and futures on a `Batch` make it impossible to reliably do an LBYL "will accept?" check.
googlebot
added
the
cla: yes
dhermes
commented
Dec 18, 2017
| if batch.will_accept(message): | ||
| future = batch.publish(message) | ||
| else: | ||
| batch = self.batch(topic, create=True) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| if not create: | ||
| batch = self._batches.get(topic) | ||
| if batch is None: | ||
| create = True |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lukesneeringer
approved these changes
Dec 18, 2017
There was a problem hiding this comment.
Discussed with @dhermes at length in Hangouts; this is approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first stage of moving that check directly into
Batch.publish(). This check must occur when the message is being published because concurrent access to the messages and futures on aBatchmake it impossible to reliably do an LBYL "will accept?" check.Towards #4575.