Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding thread prefix for ThreadPoolExecutor in Pub/Sub. #4480

Merged
merged 2 commits into from
Nov 30, 2017
Merged

Adding thread prefix for ThreadPoolExecutor in Pub/Sub. #4480

merged 2 commits into from
Nov 30, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Nov 29, 2017

This is a follow-on to #4474 and #4476.

@dhermes dhermes added api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern. labels Nov 29, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 29, 2017
dhermes
dhermes commented Nov 29, 2017
View reviewed changes
pubsub/google/cloud/pubsub_v1/subscriber/policy/thread.py Outdated
executor = futures.ThreadPoolExecutor(max_workers=10)
executor = futures.ThreadPoolExecutor(
max_workers=10,
thread_name_prefix='ThreadPoolExecutor-SubscriberPolicy',

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor Author

dhermes commented Nov 29, 2017

This feature is not present in the concurrent.futures backport, but has been checked into their source tree (agronholm/pythonfutures#63).

@theacodes
Copy link
Contributor

This feature is not present in the concurrent.futures backport, but has been checked into their source tree (agronholm/pythonfutures#63).

great. Can we turn it on for Python 3 for now?

@dhermes
Copy link
Contributor Author

dhermes commented Nov 29, 2017

@jonparrott We can, but the maintainer of the backport indicated he may do a release soon, so it might be worth waiting (if it's on the order of a day).

@dhermes dhermes mentioned this pull request Nov 30, 2017
Closed
@dhermes dhermes merged commit 94617d8 into googleapis:master Nov 30, 2017
@dhermes dhermes deleted the pubsub-name-executor branch November 30, 2017 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

@theacodes theacodes

Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhermes @theacodes @lukesneeringer @tseaver @googlebot