Fix RuntimeError: set_exception can only be called once #4380
Conversation
googlebot
added
the
cla: yes
|
@PicardParis Thanks for the patch! I'll defer to @lukesneeringer about the details, but we need to add one or more testcases / assertions which verify both new codepaths. |
Also allow `posargs` to be passed through for `nox -s unit` in Pub/Sub.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
googlebot
added
cla: no
| self._future.set_exception(exception) | ||
| if self._future.done(): | ||
| # Simply trigger the future. | ||
| self._future._trigger() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Also modifying a unit test to call `policy.on_exception()` **outside** of an "assert raises". I noticed these issues during review of googleapis#4380.
Also modifying a unit test to call `policy.on_exception()` **outside** of an "assert raises". I noticed these issues during review of #4380.
|
@PicardParis Thanks a lot for taking the time to write and send this patch. Reading it and writing tests for it certainly helped me understand the implementation as I started to dig in. After debugging reproducible cases for #4463, it's clear that this approach is not the right one, so we'll be closing this PR. Thanks! |
No description provided.