Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document deepcopy semantics of complex bucket properties. #3712

Merged
merged 1 commit into from
Aug 1, 2017
Merged

Document deepcopy semantics of complex bucket properties. #3712

merged 1 commit into from
Aug 1, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 1, 2017

cors, labels, and lifecycle_rules all return copies of the values: changes to them have no effect until the copy is reassigned via the property's setter.

Closes #3710

- 'cors', 'labels', and 'lifecycle_rules' all return copies of the
  values:  changes to them have no effect until the copy is reassigned
  via the property's setter.

Closes #3710
@tseaver tseaver added api: storage Issues related to the Cloud Storage API. docs labels Aug 1, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2017
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll let @jonparrott have final say

@tseaver
Copy link
Contributor Author

tseaver commented Aug 1, 2017

Merging w/o waiting for slow CI because this is a docstring-only change, and I've verified that docs build locally.

@tseaver tseaver merged commit ac23b77 into googleapis:master Aug 1, 2017
@tseaver tseaver deleted the 3710-storage-bucket_labels_docstrings branch August 1, 2017 20:01
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
…#3712)

'cors', 'labels', and 'lifecycle_rules' all return copies of the
values:  changes to them have no effect until the copy is reassigned
via the property's setter.

Closes googleapis#3710
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
…#3712)

'cors', 'labels', and 'lifecycle_rules' all return copies of the
values:  changes to them have no effect until the copy is reassigned
via the property's setter.

Closes googleapis#3710
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
…#3712)

'cors', 'labels', and 'lifecycle_rules' all return copies of the
values:  changes to them have no effect until the copy is reassigned
via the property's setter.

Closes googleapis#3710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants