Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sentence about row ordering #3504

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Add sentence about row ordering #3504

merged 1 commit into from
Jun 19, 2017

Conversation

garye
Copy link
Contributor

@garye garye commented Jun 15, 2017

I'm not sure if this is the best place for this, but we want to make sure it's documented that rows are returned in row key order.

@garye
Add sentence about row ordering
75e1a93 
I'm not sure if this is the best place for this, but we want to make sure it's documented that rows are returned in row key order.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2017
dhermes
dhermes approved these changes Jun 15, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It might be worth adding a similar note in consume_all?

@dhermes
Copy link
Contributor

dhermes commented Jun 15, 2017

@garye Let us know if you want this merged, otherwise we'll look forward to any other docs changes you send

@garye
Copy link
Contributor Author

garye commented Jun 15, 2017

consume_all puts everything into a map keyed by row key so we'd lose the order, right? If that's true then go ahead and merge this one...

Thanks!

@dhermes
Copy link
Contributor

dhermes commented Jun 19, 2017

@garye consume_all just calls consume_next until the stream is exhausted

@dhermes dhermes merged commit 7e3fae0 into googleapis:master Jun 19, 2017
@tseaver tseaver added api: bigtable Issues related to the Bigtable API. docs labels Jun 19, 2017
@tseaver tseaver mentioned this pull request Jun 26, 2017
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@garye @landrito
Add sentence about row ordering (googleapis#3504)
b3bc435 
I'm not sure if this is the best place for this, but we want to make sure it's documented that rows are returned in row key order.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@garye @landrito
Add sentence about row ordering (googleapis#3504)
06bf8fd 
I'm not sure if this is the best place for this, but we want to make sure it's documented that rows are returned in row key order.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@garye @landrito
Add sentence about row ordering (googleapis#3504)
f1c4e81 
I'm not sure if this is the best place for this, but we want to make sure it's documented that rows are returned in row key order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garye @dhermes @tseaver @googlebot