-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding datastore Key.(to|from)_legacy_urlsafe. #3491
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
134ae80
Adding bare-minimum proto for converting legacy App Engine "Reference…
dhermes 72e26b7
Rough draft of working implementation of datastore Key.(to|from)_lega…
dhermes 36d9abc
Adding implementation for datastore Key.to_legacy_urlsafe().
dhermes 92779fd
Adding _onestore_v3_pb2 to ignored files for flake8.
dhermes 22097ff
Addressing @jonparrott feedback.
dhermes bb87e62
Adding test coverage for helpers needed for Key.(to|from)_legacy_urls…
dhermes 30a84ff
Adding LICENSE header to hand-written legacy GAE proto.
dhermes d32361e
Renaming _onestore_v3.proto --> _app_engine_key.proto.
dhermes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
syntax = "proto2"; | ||
|
||
message Reference { | ||
required string app = 13; | ||
optional string name_space = 20; | ||
required Path path = 14; | ||
optional string database_id = 23; | ||
} | ||
|
||
message Path { | ||
repeated group Element = 1 { | ||
required string type = 2; | ||
optional int64 id = 3; | ||
optional string name = 4; | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.