Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'QueryResponse.fetch_data' return an iterator. #3484

Merged
merged 1 commit into from
Jun 9, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 7, 2017

Add a system test which exercises it.

Update snippets to match the new usage.

Closes #2840.

Add a system test which exercises it.

Update snippets to match the new usage.

Closes #2840.
@tseaver tseaver added api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 7, 2017
@tseaver tseaver requested a review from dhermes June 7, 2017 23:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 7, 2017
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit 5697b3a into master Jun 9, 2017
@tseaver tseaver deleted the 2840-bigquery-queryresults-fetch_data-iterator branch June 9, 2017 02:08
:type response: dict
:param response: The JSON API response for a page of rows in a table.
"""
iterator.query_result._set_properties(response)

This comment was marked as spam.

@dstandish
Copy link

It appears that documentation has not been updated to reflect this change, e.g. here and here.

@tswast
Copy link
Contributor

tswast commented Jul 10, 2017

The code sample on the documentation has been updated in https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/bigquery/cloud-client/async_query.py I've sent a request to republish the cloud.google.com docs page.

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
Add a system test which exercises it.

Update snippets to match the new usage.

Closes googleapis#2840.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Add a system test which exercises it.

Update snippets to match the new usage.

Closes googleapis#2840.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Add a system test which exercises it.

Update snippets to match the new usage.

Closes googleapis#2840.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants