Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reloading BigQuery table in system test before fetching data. #3468

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Reloading BigQuery table in system test before fetching data. #3468

merged 1 commit into from
Jun 2, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jun 2, 2017

@dhermes dhermes added api: bigquery Issues related to the BigQuery API. build type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 2, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 2, 2017
@dhermes
Copy link
Contributor Author

dhermes commented Jun 2, 2017

The build has already passed the b0rken test case, so fingers crossed here.

@dhermes dhermes mentioned this pull request Jun 2, 2017
Merged
@theacodes theacodes merged commit 38bdb44 into master Jun 2, 2017
@theacodes theacodes deleted the fix-bigquery branch June 2, 2017 21:44
@tseaver
Copy link
Contributor

tseaver commented Jun 5, 2017

It is clearly a good fix.

@tseaver
Copy link
Contributor

tseaver commented Jun 5, 2017

When I merged #3426, we were in the midst of a spate of logging system test failures, which meant we didn't notice the new error it introduced.

@dhermes
Copy link
Contributor Author

dhermes commented Jun 5, 2017

👍 Thanks @tseaver

@dhermes dhermes mentioned this pull request Jun 6, 2017
Closed
@tseaver tseaver mentioned this pull request Jun 26, 2017
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@dhermes @landrito
Reloading BigQuery table in system test before fetching data. (google…
ac68480 
…apis#3468)

e.g. https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2065

Error introduced in googleapis#3426.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@dhermes @landrito
Reloading BigQuery table in system test before fetching data. (google…
f4e794a 
…apis#3468)

e.g. https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2065

Error introduced in googleapis#3426.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@dhermes @landrito
Reloading BigQuery table in system test before fetching data. (google…
827a8ad 
…apis#3468)

e.g. https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2065

Error introduced in googleapis#3426.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

@theacodes theacodes

Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhermes @tseaver @lukesneeringer @theacodes @googlebot