Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement flush for cloud logging handlers #3413

Merged
merged 2 commits into from
May 12, 2017
Merged

Implement flush for cloud logging handlers #3413

merged 2 commits into from
May 12, 2017

Conversation

theacodes
Copy link
Contributor

No description provided.

@theacodes theacodes added the api: logging Issues related to the Cloud Logging API. label May 12, 2017
@theacodes theacodes requested a review from dhermes May 12, 2017 22:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 12, 2017
dhermes
dhermes reviewed May 12, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LG

logging/google/cloud/logging/handlers/transports/base.py Outdated

For blocking/sync transports, this is a no-op.
"""
pass

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

logging/tests/unit/handlers/transports/test_background_thread.py Outdated
worker = self._make_one(_Logger(self.NAME))

# Queue is empty, should not block.
worker.flush()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

logging/tests/unit/handlers/transports/test_base.py

def test_flush_is_abstract_and_optional(self):
target = self._make_one()
target.flush()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented May 12, 2017

LGTM pending CI

@theacodes theacodes merged commit 2d63cda into googleapis:master May 12, 2017
@theacodes theacodes deleted the implement-flush branch May 15, 2017 15:57
@tseaver tseaver mentioned this pull request Jun 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes left review comments

Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theacodes @dhermes @googlebot