Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #272: add 'allocate_ids' RPC to connection #299

Merged
merged 4 commits into from
Oct 28, 2014
Merged

Fix #272: add 'allocate_ids' RPC to connection #299

merged 4 commits into from
Oct 28, 2014

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 27, 2014

To ease comparison with the protobuf spec:

  • Reorders other RPC methods to match the order in the protobuf spec
  • Renames 'Connection.rollback_transaction' -> 'rollback'.

dhermes
dhermes reviewed Oct 27, 2014
View reviewed changes
gcloud/datastore/connection.py
@@ -153,48 +153,72 @@ def dataset(self, *args, **kwargs):
kwargs['connection'] = self
return Dataset(*args, **kwargs)

def begin_transaction(self, dataset_id, serializable=False):
"""Begin a transaction.
#

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Oct 27, 2014

The idea behind the rename is to match all the SomethingRequest classes defined in the proto?

If yes, I am a fan of this. If no, how serendipitous.

@dhermes
Copy link
Contributor

dhermes commented Oct 27, 2014

Sorry for I started reviewing lookup before I realized that ada09e1 happened and confused diff and git diff.

Before I accidentally complain about non-changes, were there actual code changes in that commit or just re-org?

@tseaver
Copy link
Contributor Author

tseaver commented Oct 27, 2014

Yes, matching the Request/Response classes, as well as the RPCs

@tseaver
Copy link
Contributor Author

tseaver commented Oct 27, 2014

  • ada09e1 is only reordering the methods which map RPCs.
  • d5882e3 is only the 'rollback_transaction' -> 'rollback' rename.
  • eff498d adds the 'allocate_ids' method.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling eff498d on tseaver:272-add-allocate_ids-rpc into 6f26e98 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor

dhermes commented Oct 27, 2014

Both eff498d and d5882e3 LGTM but I want to try to somehow check ada09e1.

As for the re-org Connection / Dataset stuff, we can take that to another PR. I would prefer you remove the section header though since it breaks / introduces convention within this project.

@tseaver
Note protobuf RPCs mapped by connection methods.
162f508 
Remove section header comments, per @dhermes feedback.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 162f508 on tseaver:272-add-allocate_ids-rpc into 6f26e98 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor

dhermes commented Oct 28, 2014

OK I verified ada09e1

LGTM

I am afk (on phone) right now. Feel free to create a tracking issue for the breakup of the Connection class before merging this.

@tseaver tseaver mentioned this pull request Oct 28, 2014
Closed
tseaver added a commit that referenced this pull request Oct 28, 2014
@tseaver
Merge pull request #299 from tseaver/272-add-allocate_ids-rpc
7d155f7 
Fix #272: add 'allocate_ids' RPC to connection
@tseaver tseaver merged commit 7d155f7 into googleapis:master Oct 28, 2014
@tseaver tseaver deleted the 272-add-allocate_ids-rpc branch October 28, 2014 02:16
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020
Merge pull request googleapis#299 from shyamdsundar/master
8739a8f 
Fix "keyerror" issue in beautifulsoup while checking attribute.
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
chore: use python-samples-reviewers (#299)
d10cb17
atulep pushed a commit that referenced this pull request Apr 18, 2023
@gcf-owl-bot
chore: use python-samples-reviewers (#299)
1e36bc5
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
docs: Fix formatting of request arg in docstring (#299)
e172817 
* docs: Fix formatting of request arg in docstring

chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533

Source-Link: googleapis/googleapis@8a085ae

Source-Link: googleapis/googleapis-gen@b2ab4b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Jun 4, 2023
@renovate-bot @parthea
chore(deps): update all dependencies (#299)
6448767 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore: detect samples tests in nested directories (#299)
fd073d9 
Source-Link: googleapis/synthtool@50db768
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-datalabeling to v1.8.0 (#299
db8cadf 
)
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-talent to v2.7.3 (#299)
b706d1d
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-pubsub to v2.11.0 (#299)
26d6f64
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): auto approve template changes (#299)
c7e1580 
Source-Link: googleapis/synthtool@453a5d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32
parthea pushed a commit that referenced this pull request Jul 6, 2023
@renovate-bot
chore(deps): update dependency google-api-python-client to v2.44.0 (#299
be1fe3f 
)
parthea pushed a commit that referenced this pull request Aug 15, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.2 (#299)
53a5296
parthea added a commit that referenced this pull request Sep 20, 2023
@kchertenko @parthea
chore(samples): remove env setup (#299)
bcee271 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 20, 2023
@irataxy
docs(samples): remove restriction of JPEGs only for overlay images (#299
008cdad 
)
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@release-please
chore: release 2.3.0 (#299)
2890672 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 1.11.0 (#299)
722652f 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-pubsub to v2.10.0 (#299)
4d696dc
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: fix path to requirements.txt in release script [autoapprove] (#…
65691d8 
…299)

Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-container to v2.12.0 (#299)
1cc06ca
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-dataproc to v3.1.1 (#299)
7e55df7
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): drop flake8-import-order in samples noxfile (#299)
42c2076 
Source-Link: googleapis/synthtool@6ed3a83
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 22, 2023
@renovate-bot @parthea
chore(deps): update dependency pytest to v7.1.3 (#299)
6c619a0 
* chore(deps): update all dependencies

* revert

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-bigquery to v2.27.0 (#299)
3e11c69 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [google-cloud-bigquery](https://togithub.com/googleapis/python-bigquery) | `==2.26.0` -> `==2.27.0` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-bigquery/2.27.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-bigquery/2.27.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-bigquery/2.27.0/compatibility-slim/2.26.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-bigquery/2.27.0/confidence-slim/2.26.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/python-bigquery</summary>

### [`v2.27.0`](https://togithub.com/googleapis/python-bigquery/blob/master/CHANGELOG.md#&#8203;2270-httpswwwgithubcomgoogleapispython-bigquerycomparev2260v2270-2021-09-24)

[Compare Source](https://togithub.com/googleapis/python-bigquery/compare/v2.26.0...v2.27.0)

##### Features

-   Add py.typed for PEP 561 compliance ([#&#8203;976](https://www.togithub.com/googleapis/python-bigquery/issues/976)) ([96e6bee](https://www.github.com/googleapis/python-bigquery/commit/96e6beef3c63b663b7e5879b1458f4dd1a47a5b5))
-   include key metadata in Job representation ([#&#8203;964](https://www.togithub.com/googleapis/python-bigquery/issues/964)) ([acca1cb](https://www.github.com/googleapis/python-bigquery/commit/acca1cb7baaa3b00508246c994ade40314d421c3))

##### Bug Fixes

-   Arrow extension-type metadata was not set when calling the REST API or when there are no rows ([#&#8203;946](https://www.togithub.com/googleapis/python-bigquery/issues/946)) ([864383b](https://www.github.com/googleapis/python-bigquery/commit/864383bc01636b3774f7da194587b8b7edd0383d))
-   disambiguate missing policy tags from explicitly unset policy tags ([#&#8203;983](https://www.togithub.com/googleapis/python-bigquery/issues/983)) ([f83c00a](https://www.github.com/googleapis/python-bigquery/commit/f83c00acead70fc0ce9959eefb133a672d816277))
-   remove default timeout ([#&#8203;974](https://www.togithub.com/googleapis/python-bigquery/issues/974)) ([1cef0d4](https://www.github.com/googleapis/python-bigquery/commit/1cef0d4664bf448168b26487a71795144b7f4d6b))

##### Documentation

-   simplify destination table sample with f-strings ([#&#8203;966](https://www.togithub.com/googleapis/python-bigquery/issues/966)) ([ab6e76f](https://www.github.com/googleapis/python-bigquery/commit/ab6e76f9489262fd9c1876a1c4f93d7e139aa999))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-asset).
parthea added a commit that referenced this pull request Oct 21, 2023
@m-strzelczyk @parthea @gcf-owl-bot
docs(samples): Bulk insert sample (#299)
c69dde9 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: add prerelease nox session (#299)
b1e9e20 
Source-Link: googleapis/synthtool@050953d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:65e656411895bff71cffcae97246966460160028f253c2e45b7a25d805a5b142

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@parthea @dandhlee
fix(deps): require protobuf <4.0.0dev (#299)
5a544f3 
* fix(deps): require protobuf <4.0.0dev

* chore(deps): bump grpc-google-iam-v1 version

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): use black==22.3.0 (#299)
fb3fa98 
Source-Link: googleapis/synthtool@6fab84a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7cffbc10910c3ab1b852c05114a08d374c195a81cdec1d4a67a1d129331d0bfe

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-texttospeech to v2.8.0 (#299
afbfb49 
)
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
chore: make samples 3.6 check optional (#299)
23608a3
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
chore: Update to gapic-generator-python 1.6.0 (#299)
005b731 
* chore: Update to gapic-generator-python 1.6.0

feat(python): Add typing to proto.Message based class attributes

feat(python): Snippetgen handling of repeated enum field

PiperOrigin-RevId: 487326846

Source-Link: googleapis/googleapis@da380c7

Source-Link: googleapis/googleapis-gen@61ef576
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjFlZjU3NjJlZTY3MzFhMGNiYmZlYTIyZmQwZWVjZWU1MWFiMWM4ZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: new APIs added to reflect updates to the filestore service

- Add ENTERPRISE Tier
- Add snapshot APIs: RevertInstance, ListSnapshots, CreateSnapshot, DeleteSnapshot, UpdateSnapshot
- Add multi-share APIs: ListShares, GetShare, CreateShare, DeleteShare, UpdateShare
- Add ConnectMode to NetworkConfig (for Private Service Access support)
- New status codes (SUSPENDED/SUSPENDING, REVERTING/RESUMING)
- Add SuspensionReason (for KMS related suspension)
- Add new fields to Instance information: max_capacity_gb, capacity_step_size_gb, max_share_count, capacity_gb, multi_share_enabled

PiperOrigin-RevId: 487492758

Source-Link: googleapis/googleapis@5be5981

Source-Link: googleapis/googleapis-gen@ab0e217
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWIwZTIxN2Y1NjBjYzJjMWFmYzExNDQxYzJlYWI2YjY5NTBlZmQyYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix docs build

* fix repo url in setup.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
chore: regenerate samples (#299)
e47b1f8 
* chore(bazel): update protobuf to v3.21.7

PiperOrigin-RevId: 477955264

Source-Link: googleapis/googleapis@a724450

Source-Link: googleapis/googleapis-gen@4abcbca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGFiY2JjYWVjODU1ZTc0YTBiMjJhNDk4OGNmOWUwZWI2MWE4MzA5NCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
chore: use python-samples-reviewers (#299)
927a23f
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.4 (#299)
97f6193 
* chore: Update gapic-generator-python to v1.8.4

PiperOrigin-RevId: 507808936

Source-Link: googleapis/googleapis@64cf849

Source-Link: googleapis/googleapis-gen@53c48ca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @coveralls