Fix bug with speech streaming speech_context. #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
14 tasks
|
Can you add a system test to exercise this fix? |
|
@dhermes added system-tests runtests: commands[1] | python /Users/daspecster/Documents/google/google-cloud-py/system_tests/attempt_system_tests.py speech
test_async_recognize_gcs_file (speech.TestSpeechClient) ... _operation_complete. Trying again in 1 seconds...
_operation_complete. Trying again in 2 seconds...
_operation_complete. Trying again in 4 seconds...
ok
test_async_recognize_local_file (speech.TestSpeechClient) ... _operation_complete. Trying again in 1 seconds...
_operation_complete. Trying again in 2 seconds...
_operation_complete. Trying again in 4 seconds...
ok
test_stream_recognize (speech.TestSpeechClient) ... ok
test_stream_recognize_interim_results (speech.TestSpeechClient) ... ok
test_stream_recognize_single_utterance (speech.TestSpeechClient) ... ok
test_sync_recognize_gcs_file (speech.TestSpeechClient) ... ok
test_sync_recognize_local_file (speech.TestSpeechClient) ... ok
409 The bucket you tried to delete was not empty. (DELETE https://www.googleapis.com/storage/v1/b/new_1478803671769), Trying again in 1 seconds...
----------------------------------------------------------------------
Ran 7 tests in 33.971s
OK
E1110 13:48:35.789352000 140736417121216 network_status_tracker.c:48] Memory leaked as all network endpoints were not shut down
_____________________________________________________ summary _____________________________________________________
system-tests: commands succeeded
congratulations :) |
|
LGTM once CIs go green? Did you run to verify? UPDATE: Jinx |
|
@dhermes the tests would just get skipped since streaming only works with gRPC anyway. |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…ng-speech-context-bug Fix bug with speech streaming speech_context.
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
…context-bug Fix bug with speech streaming speech_context.
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
…context-bug Fix bug with speech streaming speech_context.
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
…context-bug Fix bug with speech streaming speech_context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is the correct resolution to
mentioned in #2522.
Speech streaming wasn't converting the list of hints to an instance of
SpeechContextbefore flight.