Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #239: remove / document 'pragma: NO COVER' #248

Merged
merged 17 commits into from
Oct 17, 2014
Merged

Fix #239: remove / document 'pragma: NO COVER' #248

merged 17 commits into from
Oct 17, 2014

Commits on Oct 16, 2014

  1. Don't suppress coverage for gcloud.datastore.key.Key.parent.

    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    42f74e9 View commit details
    Browse the repository at this point in the history

  2. Add explicit coverage for gcloud.datastore.acl.ACL.get_entities.

    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    b0dcc01 View commit details
    Browse the repository at this point in the history

  3. Don't suppress coverage for gcloud.storage.acl.ACL.save.

    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    a1aea7d View commit details
    Browse the repository at this point in the history

  4. Don't suppress coverage for gcloud.storage.iterator.Iterator.get_item… 

    …s_from_response.
    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    9583fbe View commit details
    Browse the repository at this point in the history

  5. Don't remap (only some) IOError. 

    Fixes bug for errno != ENOSPC.
    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    9cfb628 View commit details
    Browse the repository at this point in the history

  6. Don't suppress coverage for gcloud.storage.key.Key.generate_signed_url.

    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    806d08a View commit details
    Browse the repository at this point in the history

  7. Don't suppress coverage for gcloud.connetion.Connection.generate_sign… 

    …ed_url.

Borrow @dhermes' factoring of '_get_expiration_seconds', but make it
a free function rather than a static method, and make the testes more
fine-grained.
    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    13b0550 View commit details
    Browse the repository at this point in the history

  8. Drop 'pragma: NO COVER' for '__repr__' methods. 

    Suppress coverage for them instead via .coveragerc.
    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    a3737e6 View commit details
    Browse the repository at this point in the history

  9. Document non-coverage of non-testing path through '_utcnow'.

    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    0f3828a View commit details
    Browse the repository at this point in the history

  10. Drop comments replicating docstring info. 

    Incorporates feedback from @dhermes.
    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    84e181e View commit details
    Browse the repository at this point in the history

  11. Fix fussiness introduced by .coveragerc change.

    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    6497cd3 View commit details
    Browse the repository at this point in the history

  12. Avoid extra 'if _UTCNOW is not None:' check. 

    Incorporate feedback from @dhermes.
    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    868506b View commit details
    Browse the repository at this point in the history

  13. lint.

    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    63eb552 View commit details
    Browse the repository at this point in the history

  14. Dead chickens for pep8 E124.

    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    4c7b14b View commit details
    Browse the repository at this point in the history

  15. Typo. 

    Incorporate feedback from @dhermes.
    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    a6bf98f View commit details
    Browse the repository at this point in the history

  16. Merge branch 'master' into 239-remove_pragma_no_cover

    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    e6bc14e View commit details
    Browse the repository at this point in the history

  17. Merge with master to pick up PR #250.

    @tseaver
    tseaver committed Oct 16, 2014
    Configuration menu
    Copy the full SHA
    2338955 View commit details
    Browse the repository at this point in the history