Suppress two useless PEP8 errors.

[tseaver]

• E124: closing bracket does not match visual indentation.
• E127: continuation line over-indented for visual indent.

They are over-opinionated, and without sufficient justification from the PEP.

[dhermes]

I don't find this to be useless.

---

RE: E124 If nothing else, this codebase has an inconsistent / undefined convention for how to do it. I personally think expressions / statements like

function_to_call(arg0,
                 arg1,
                 arg2,
                 arg3
                 )

my_dict = {'key0': 0,
           'key1': 0,
           'key2': 0
           }

are unsightly and prefer putting the closing either with the last entry or aligning it at the current indent level (this is done throughout the Google Style Guide). For example:

function_to_call(arg2,
                 arg1,
                 arg2,
                 arg3)

my_dict = {
    'key0': 0,
    'key1': 0,
    'key2': 0
}

---

E127 certainly has justification from the PEP:

..When using a hanging indent the following considerations should be applied;
there should be no arguments on the first line and further indentation should
be used to clearly distinguish itself as a continuation line...

Example:

# More indentation included to distinguish this from the rest.
def long_function_name(
        var_one, var_two, var_three,
        var_four):
    print(var_one)

[tseaver]

Keeping the closing marker on the line with the last item makes for multi-line diffs when items are added at the end. (Likewise the Javascript-influenced dropping of the trailing comma).

Pulling the closing bracket leftward (rather than below its opposite pair does nothing to improve by-eye matching, for me.

But the worst part about the pep8 output for the error is that it gives no clue what is expected.

[dhermes]

There are pros and cons to everything, but these errors don't result in worse code and when the do occur encourage closer inspection.

I don't think the appearance of our diffs should influence decisions in our code.

As for by-eye matching, I'm fine going against my personal preference, so long as we have a well-defined rule for this project and we stick to it.

At any rate, I think we should close out this PR.

[tseaver]

We can make the conflict between PEP8 and pylint go away another way.