Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding retries for failed copy_blob() calls in system tests. #2290

Merged
merged 1 commit into from
Sep 9, 2016
Merged

Adding retries for failed copy_blob() calls in system tests. #2290

merged 1 commit into from
Sep 9, 2016
+18 −4

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 9, 2016

Fixes #2289.

I ran it locally until I could force the error:

(system-tests) $ .tox/system-tests/bin/nosetests system_tests/storage.py -vv --nocapture
nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$']
test_create_bucket (storage.TestStorageBuckets) ... ok
test_list_buckets (storage.TestStorageBuckets) ... ok
test_list_files (storage.TestStorageListFiles) ... ok
test_paginate_files (storage.TestStorageListFiles) ... ok
400 No file found in request. (POST https://www.googleapis.com/storage/v1/b/new_1473450503532/o/file01.txt/copyTo/b/new_1473450503532/o/parent%2Fchild%2Ffile21.txt), Trying again in 1 seconds...
400 No file found in request. (POST https://www.googleapis.com/storage/v1/b/new_1473450503532/o/file01.txt/copyTo/b/new_1473450503532/o/parent%2Fchild%2Ffile21.txt), Trying again in 2 seconds...
400 No file found in request. (POST https://www.googleapis.com/storage/v1/b/new_1473450503532/o/file01.txt/copyTo/b/new_1473450503532/o/parent%2Fchild%2Fgrand%2Ffile31.txt), Trying again in 1 seconds...
test_first_level (storage.TestStoragePseudoHierarchy) ... ok
test_root_level_w_delimiter (storage.TestStoragePseudoHierarchy) ... ok
test_second_level (storage.TestStoragePseudoHierarchy) ... ok
test_third_level (storage.TestStoragePseudoHierarchy) ... ok
test_create_signed_delete_url (storage.TestStorageSignURLs) ... ok
test_create_signed_read_url (storage.TestStorageSignURLs) ... ok
test_copy_existing_file (storage.TestStorageWriteFiles) ... ok
test_direct_write_and_read_into_file (storage.TestStorageWriteFiles) ... ok
test_large_file_write_from_stream (storage.TestStorageWriteFiles) ... ok
test_small_file_write_from_filename (storage.TestStorageWriteFiles) ... ok
test_write_metadata (storage.TestStorageWriteFiles) ... ok

----------------------------------------------------------------------
Ran 15 tests in 26.949s

OK

@dhermes dhermes added api: storage Issues related to the Cloud Storage API. testing flaky labels Sep 9, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2016
tseaver
tseaver reviewed Sep 9, 2016
View reviewed changes
system_tests/storage.py
@@ -47,6 +57,7 @@ class Config(object):


def setUpModule():
_helpers.PROJECT = TESTS_PROJECT

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Sep 9, 2016

LGTM

@dhermes dhermes merged commit 3072014 into googleapis:master Sep 9, 2016
@dhermes dhermes deleted the fix-2289 branch September 9, 2016 21:52
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @tseaver @daspecster @googlebot