Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll async jobs using correct state logic in BQ usage docs. #2251

Merged
merged 1 commit into from
Sep 6, 2016
Merged

Poll async jobs using correct state logic in BQ usage docs. #2251

merged 1 commit into from
Sep 6, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 6, 2016

Closes: #2119.

@tseaver tseaver added docs api: bigquery Issues related to the BigQuery API. labels Sep 6, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 6, 2016
@dhermes
Copy link
Contributor

dhermes commented Sep 6, 2016

LGTM. Does the state come back from the server? Should we normalize to ensure it is always uppercase (or lowercase)?

@tseaver
Copy link
Contributor Author

tseaver commented Sep 6, 2016

Does the state come back from the server?

Yes, it is read-only.

Should we normalize to ensure it is always uppercase (or lowercase)?

Likely not. We could look at adding convenience properties, e.g. job.pending, job.running, job.done, which would mask the string literals.

@tseaver tseaver merged commit 3f836eb into googleapis:master Sep 6, 2016
@tseaver tseaver deleted the 2119-bigquery-poll-jobs-using-correct-state branch September 6, 2016 20:36
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @daspecster @googlebot