-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching from nosetests to py.test. #2241
Conversation
I also created https://github.com/GoogleCloudPlatform/gcloud-python/tree/use-pytest to spawn https://ci.appveyor.com/project/dhermes/gcloud-python/build/1.0.617.use-pytest Will delete after this is verified. |
@@ -1,2 +0,0 @@ | |||
[nosetests] | |||
exclude-dir = system_tests |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
26626a2
to
19df78b
Compare
@@ -44,15 +39,18 @@ deps = | |||
basepython = | |||
python2.7 | |||
commands = | |||
{[testing]covercmd} --cover-min-percentage=100 | |||
{[testing]covercmd} | |||
coverage report --show-missing --fail-under=100 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
In the process, fixing some PATH issues in "gcloud._helpers" (path separator was explicitly provided, rather than using "os.join"). Also the the associated tests were refactored with more mocks so that they depend less on the OS.
The That job didn't fail, I just canceled it, since it would be repetetive to run both PUSH/PR for the same exact code. This should be ready to merge if I can get an LGTM. |
Lgtm On Fri, Sep 2, 2016, 4:49 PM Danny Hermes notifications@github.com wrote:
|
No description provided.