Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching from nosetests to py.test. #2241

Merged
merged 2 commits into from
Sep 3, 2016
Merged

Switching from nosetests to py.test. #2241

merged 2 commits into from
Sep 3, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 2, 2016

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Sep 2, 2016

I also created https://github.com/GoogleCloudPlatform/gcloud-python/tree/use-pytest to spawn https://ci.appveyor.com/project/dhermes/gcloud-python/build/1.0.617.use-pytest

Will delete after this is verified.

daspecster
daspecster reviewed Sep 2, 2016
View reviewed changes
setup.cfg
@@ -1,2 +0,0 @@
[nosetests]
exclude-dir = system_tests

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes dhermes force-pushed the use-pytest branch 3 times, most recently from 26626a2 to 19df78b Compare September 2, 2016 21:04
dhermes
dhermes reviewed Sep 2, 2016
View reviewed changes
tox.ini
@@ -44,15 +39,18 @@ deps =
basepython =
python2.7
commands =
{[testing]covercmd} --cover-min-percentage=100
{[testing]covercmd}
coverage report --show-missing --fail-under=100

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Adding tox support for AppVeyor.
0a7bd23 
In the process, fixing some PATH issues in "gcloud._helpers"
(path separator was explicitly provided, rather than using
"os.join"). Also the the associated tests were refactored
with more mocks so that they depend less on the OS.
@dhermes
Copy link
Contributor Author

dhermes commented Sep 2, 2016

The continuous-integration/travis-ci/push check came up because I pushed theGoogleCloudPlatform/gcloud-python:use-pytest branch to this project. (I did it so that the AppVeyor tests would spawn, mentioned above.)

That job didn't fail, I just canceled it, since it would be repetetive to run both PUSH/PR for the same exact code.

This should be ready to merge if I can get an LGTM.

@theacodes
Copy link
Contributor

Lgtm

On Fri, Sep 2, 2016, 4:49 PM Danny Hermes notifications@github.com wrote:

The continuous-integration/travis-ci/push check came up because I pushed
theGoogleCloudPlatform/gcloud-python:use-pytest branch to this project.
(I did it so that the AppVeyor tests would spawn, mentioned above.)

That job didn't fail, I just canceled it, since it would be repetetive to
run both PUSH/PR for the same exact code.

This should be ready to merge if I can get an LGTM.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#2241 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUczhDUyiQmLqvqj2h4ZD2C7wdYa8bks5qmLXugaJpZM4Jz_YD
.

@dhermes dhermes merged commit d586990 into googleapis:master Sep 3, 2016
@dhermes dhermes deleted the use-pytest branch September 3, 2016 00:18
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

@theacodes theacodes

Labels
cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhermes @theacodes @daspecster @tseaver @googlebot