Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vision label detection #2237

Merged
merged 1 commit into from
Sep 15, 2016
Merged

Add vision label detection #2237

merged 1 commit into from
Sep 15, 2016

Conversation

daspecster
Copy link
Contributor

@daspecster daspecster commented Sep 1, 2016 •
edited
Loading

Based off of #2236.

I was able to DRY up the requests code for the EntityAnnotation based detection types.

✅ Waiting for #2236 before rebasing.

@daspecster daspecster added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: vision Issues related to the Cloud Vision API. labels Sep 1, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2016
@daspecster daspecster force-pushed the vision-label-detection branch 2 times, most recently from 8395fa7 to c49f0c2 Compare September 12, 2016 14:52
@daspecster daspecster mentioned this pull request Sep 12, 2016
Merged
@daspecster daspecster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 12, 2016
@daspecster
Copy link
Contributor Author

@tseaver LMKWYT!

tseaver
tseaver reviewed Sep 14, 2016
View reviewed changes
google/cloud/vision/entity.py
bounds = Bounds.from_api_repr(response['boundingPoly'])
bounds = []
if 'boundingPoly' in response:
bounds = Bounds.from_api_repr(response['boundingPoly'])

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver
tseaver reviewed Sep 14, 2016
View reviewed changes
google/cloud/vision/entity.py
bounds = []
if 'boundingPoly' in response:
bounds = Bounds.from_api_repr(response['boundingPoly'])
bounds = Bounds.from_api_repr(response.get('boundingPoly', {}))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/cloud/vision/geometry.py
vertices.append(Vertex(vertex.get('x', None),
vertex.get('y', None)))
vertices = [Vertex(vertex.get('x', None), vertex.get('y', None)) for
vertex in response_vertices.get('vertices', [])]

This comment was marked as spam.

Sign in to view

@daspecster
Copy link
Contributor Author

@tseaver anything else?

@tseaver
Copy link
Contributor

tseaver commented Sep 14, 2016

LGTM pending Travis.

@daspecster
Copy link
Contributor Author

Squashed...going to wait for travis one more time.

@daspecster daspecster merged commit 143b0a1 into googleapis:master Sep 15, 2016
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
@daspecster daspecster deleted the vision-label-detection branch January 24, 2017 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

Assignees

@tseaver tseaver

Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daspecster @tseaver @dhermes @googlebot