-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vision API connection. #2167
Conversation
Looks fine but Travis is failing. |
API_VERSION = 'v1' | ||
"""The version of the API, used in building the API call's URL.""" | ||
|
||
API_URL_TEMPLATE = '{api_base_url}/{api_version}{path}' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
It was failing, I believe because I didn't have the RST for it in there. Also I added an API URL example. |
@@ -629,7 +629,8 @@ def main(): | |||
'resource_manager': [], | |||
'storage': [], | |||
'streaming': [], | |||
'translate': [] | |||
'translate': [], | |||
'vision': [] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
LGTM once Travis passes though you should squash if not too inconvenient |
38476b5
to
00c05e9
Compare
Wow travis...what's the deal? |
@daspecster I'm guessing the conflict is in |
Yeah Travis has been slow. And in the 35 minutes since you posted that, I did give you a conflict. Sorry. |
Add RST and ignore vision.__init__. Add API URL example. Add vision to TOCs. Add trailing comma. Add vision/connection to toc.json.
00c05e9
to
2cf3a90
Compare
Conflict resolved....back to waiting on travis. |
Finally! |
As per a conversation about small PR's with @dhermes, here is Vision's connection class.
This is pretty simple, just adding the needed scope.