-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding 429 retry in storage for bucket create and delete. #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Aug 22, 2016
(Pdb) print(content)
{
"error": {
"errors": [
{
"domain": "usageLimits",
"reason": "rateLimitExceeded",
"message": "The project exceeded the rate limit for creating and deleting buckets."
}
],
"code": 429,
"message": "The project exceeded the rate limit for creating and deleting buckets."
}
}
(Pdb) print(json.dumps(response, indent=2))
{
"status": "429",
"alternate-protocol": "443:quic",
"content-length": "301",
"x-xss-protection": "1; mode=block",
"x-content-type-options": "nosniff",
"transfer-encoding": "chunked",
"expires": "Mon, 22 Aug 2016 21:10:37 GMT",
"vary": "Origin, X-Origin",
"server": "GSE",
"-content-encoding": "gzip",
"cache-control": "private, max-age=0",
"date": "Mon, 22 Aug 2016 21:10:37 GMT",
"x-frame-options": "SAMEORIGIN",
"alt-svc": "quic=\":443\"; ma=2592000; v=\"35,34,33,32,31,30\"",
"content-type": "application/json; charset=UTF-8"
}
(Pdb) exc = make_exception(response, content, error_info=method + ' ' + url)
(Pdb) print(json.dumps(exc.errors, indent=2))
[
{
"reason": "rateLimitExceeded",
"domain": "usageLimits",
"message": "The project exceeded the rate limit for creating and deleting buckets."
}
] |
LGTM once pylint is appeased. |
dhermes
force-pushed
the
rate-limit-storage-buckets
branch
from
August 23, 2016 00:37
bf34b44
to
ca74a4a
Compare
Merged
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161) * adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161) * adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161) * adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161) * adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues * fixed some travis ci lint issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the Cloud Storage API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showed up when Travis when 3 merge builds right on top of each other:
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/154249353
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/154251510
@tseaver I am trying to force the failure locally so I can see more fine-grained error info but 429 is pretty specific so I'm not that worried. I also would like to add a debug flag so we get more error info in our failure messages on Travis.