Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove *s from kwargs in docstrings #2129

Merged
merged 1 commit into from
Aug 18, 2016
Merged

Conversation

waprin
Copy link
Contributor

@waprin waprin commented Aug 18, 2016

Fixes this error:

http://stackoverflow.com/questions/30454549/a-literal-in-restructuredtext

Seems simplest/cleanest thing to do is just drop the *.s. Could alternatively follow that accepted answer's hacky solution or follow up with Sphinx, I don't see an issue about it in their issue tracker

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 18, 2016
@waprin
Copy link
Contributor Author

waprin commented Aug 18, 2016

cc @dhermes @daspecster

@tseaver tseaver merged commit f64507d into googleapis:master Aug 18, 2016
@tseaver
Copy link
Contributor

tseaver commented Aug 18, 2016

Thanks, @waprin !

@dhermes
Copy link
Contributor

dhermes commented Aug 18, 2016

@daspecster You'll want to rebase #2122 on top of master since this is covered there too

@waprin
Copy link
Contributor Author

waprin commented Aug 18, 2016

Cool created sphinx-doc/sphinx#2869 out of curiosity.

@dhermes
Copy link
Contributor

dhermes commented Aug 18, 2016

Thanks for trying to enrich the toolchain @waprin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants