Adding tox env for pubsub sys tests w / emulator. #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| host, = [line.split(_HOST_LINE_PREFIX, 1)[1] for line in env_lines | ||
| if line.startswith(_HOST_LINE_PREFIX)] | ||
| # Set environment variables before running the system tests. | ||
| os.environ[PUBSUB_EMULATOR] = host |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
tox-rule-for-pubsub-emulator
branch
from
fef1e64
to
16ebc48
Compare
|
@tseaver PTAL. I re-factored the |
dhermes
force-pushed
the
tox-rule-for-pubsub-emulator
branch
from
16ebc48
to
ce4173b
Compare
dhermes
force-pushed
the
tox-rule-for-pubsub-emulator
branch
from
ce4173b
to
2096618
Compare
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jan 28, 2016
Adding tox env for pubsub sys tests w / emulator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modeled after #1393.
Also fixes a small docs bug in
CONTRIBUTING.