Move system test runner from bash to Python #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Towards #1123 |
8 tasks
| @@ -23,12 +23,15 @@ | |||
|
|
|||
|
|
|||
| _helpers.PROJECT = TESTS_PROJECT | |||
| CLIENT = bigquery.Client() | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Also using the re-purposed `run_module_tests` to get a basic `scripts/attempt_system_tests.py` to perform all four tests as is done in `scripts/run_system_tests.sh`.
Achieved by updating `scripts/attempt_system_tests.py` to support Travis, including decrypting a key in a subprocess.
In a set-up where the tests are not intended to be run (e.g. a PR build for Travis), just importing these modules caused errors due to lack of implicit variables being set. So, all configuration done at import time was moved into `setUpClass` if there was only one `TestCase` or moved to `setUpModule` with some mutable global if there were multiple `TestCase`s.
dhermes
force-pushed
the
move-system-test-runner-to-python
branch
from
e1f4a4b
to
d6c3b87
Compare
|
@tseaver PTAL I added another commit to have all 4 system tests use |
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jan 7, 2016
Move system test runner from bash to Python
This was referenced Jan 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also re-tooling the
run_module_testsmethod to be more useful from other directories (so that we could call it from thescripts/subdirectory).