-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move system test runner from bash to Python #1349
Move system test runner from bash to Python #1349
Conversation
Towards #1123 |
@@ -23,12 +23,15 @@ | |||
|
|||
|
|||
_helpers.PROJECT = TESTS_PROJECT | |||
CLIENT = bigquery.Client() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Also using the re-purposed `run_module_tests` to get a basic `scripts/attempt_system_tests.py` to perform all four tests as is done in `scripts/run_system_tests.sh`.
Achieved by updating `scripts/attempt_system_tests.py` to support Travis, including decrypting a key in a subprocess.
In a set-up where the tests are not intended to be run (e.g. a PR build for Travis), just importing these modules caused errors due to lack of implicit variables being set. So, all configuration done at import time was moved into `setUpClass` if there was only one `TestCase` or moved to `setUpModule` with some mutable global if there were multiple `TestCase`s.
e1f4a4b
to
d6c3b87
Compare
@tseaver PTAL I added another commit to have all 4 system tests use |
LGTM |
Move system test runner from bash to Python
Also re-tooling the
run_module_tests
method to be more useful from other directories (so that we could call it from thescripts/
subdirectory).