Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove an API that was mistakenly made public #12934

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jul 25, 2024

  • Regenerate this pull request now.

PiperOrigin-RevId: 656040068

Source-Link: googleapis/googleapis@3f4e29a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/b8feb2109dde7b0938c22c993d002251ac6714dc
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRlcGxveS8uT3dsQm90LnlhbWwiLCJoIjoiYjhmZWIyMTA5ZGRlN2IwOTM4YzIyYzk5M2QwMDIyNTFhYzY3MTRkYyJ9

BEGIN_COMMIT_OVERRIDE
feat: Add support for different Pod selector labels when doing canaries
fix!: Remove an API that was mistakenly made public
END_COMMIT_OVERRIDE

BEGIN_NESTED_COMMIT

PiperOrigin-RevId: 655923660

Source-Link: googleapis/googleapis@68d8154

Source-Link: https://github.com/googleapis/googleapis-gen/commit/362c77e03bfb637dc5dd22642fc02189241d2a1b
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRlcGxveS8uT3dsQm90LnlhbWwiLCJoIjoiMzYyYzc3ZTAzYmZiNjM3ZGM1ZGQyMjY0MmZjMDIxODkyNDFkMmExYiJ9
END_NESTED_COMMIT

fix!: make changes to an API that is disabled on the server, but whose client libraries were prematurely published

PiperOrigin-RevId: 655923660

Source-Link: googleapis/googleapis@68d8154

Source-Link: googleapis/googleapis-gen@362c77e
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRlcGxveS8uT3dsQm90LnlhbWwiLCJoIjoiMzYyYzc3ZTAzYmZiNjM3ZGM1ZGQyMjY0MmZjMDIxODkyNDFkMmExYiJ9
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review July 25, 2024 16:58
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners July 25, 2024 16:58
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
PiperOrigin-RevId: 656040068

Source-Link: googleapis/googleapis@3f4e29a

Source-Link: googleapis/googleapis-gen@b8feb21
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRlcGxveS8uT3dsQm90LnlhbWwiLCJoIjoiYjhmZWIyMTA5ZGRlN2IwOTM4YzIyYzk5M2QwMDIyNTFhYzY3MTRkYyJ9
@gcf-owl-bot gcf-owl-bot bot changed the title feat: [google-cloud-deploy] add support for different Pod selector labels when doing canaries chore: [google-cloud-deploy] Update gapic-generator-python to v1.18.3 Jul 25, 2024
Copy link

snippet-bot bot commented Jul 25, 2024

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 29, 2024
@parthea
Copy link
Contributor

parthea commented Jul 29, 2024

Pending discussion in b/356112791

@parthea parthea closed this Jul 29, 2024
@parthea parthea reopened this Jul 30, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 30, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 30, 2024
@parthea parthea changed the title chore: [google-cloud-deploy] Update gapic-generator-python to v1.18.3 fix!: Remove an API that was mistakenly made public Jul 30, 2024
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 30, 2024
@parthea parthea merged commit cf7022d into main Jul 30, 2024
33 of 35 checks passed
@parthea parthea deleted the owl-bot-copy-packages-google-cloud-deploy branch July 30, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests. owl-bot-copy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant