Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new features for Places GA #11909

Merged
merged 2 commits into from
Oct 26, 2023
Merged

feat: new features for Places GA #11909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6f2cb5
feat: new features for Places GA
gcf-owl-bot[bot] Oct 23, 2023
64f34a9
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/google-maps-places/CONTRIBUTING.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,12 @@ Running System Tests
$ nox -s system

# Run a single system test
$ nox -s system- -- -k <name of test>
$ nox -s system-3.11 -- -k <name of test>


.. note::

System tests are only configured to run under Python.
System tests are only configured to run under Python 3.8, 3.9, 3.10 and 3.11.
For expediency, we do not run them in older versions of Python 3.

This alone will not run the tests. You'll need to change some local
Expand Down
6 changes: 6 additions & 0 deletions packages/google-maps-places/docs/places_v1/services_.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Services for Google Maps Places v1 API
======================================
.. toctree::
:maxdepth: 2

places
6 changes: 6 additions & 0 deletions packages/google-maps-places/docs/places_v1/types_.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Types for Google Maps Places v1 API
===================================

.. automodule:: google.maps.places_v1.types
:members:
:show-inheritance:
23 changes: 21 additions & 2 deletions packages/google-maps-places/google/maps/places/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,40 @@

from google.maps.places_v1.services.places.async_client import PlacesAsyncClient
from google.maps.places_v1.services.places.client import PlacesClient
from google.maps.places_v1.types.attribution import AuthorAttribution
from google.maps.places_v1.types.ev_charging import EVChargeOptions, EVConnectorType
from google.maps.places_v1.types.fuel_options import FuelOptions
from google.maps.places_v1.types.geometry import Circle
from google.maps.places_v1.types.photo import Photo
from google.maps.places_v1.types.place import Place, PriceLevel
from google.maps.places_v1.types.places_service import (
Int32Range,
GetPhotoMediaRequest,
GetPlaceRequest,
PhotoMedia,
SearchNearbyRequest,
SearchNearbyResponse,
SearchTextRequest,
SearchTextResponse,
)
from google.maps.places_v1.types.review import Review

__all__ = (
"PlacesClient",
"PlacesAsyncClient",
"AuthorAttribution",
"EVChargeOptions",
"EVConnectorType",
"FuelOptions",
"Circle",
"Photo",
"Place",
"PriceLevel",
"Int32Range",
Copy link
Contributor

@parthea parthea Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a breaking change. See the discussion in cl/575913105 to determine whether breaking changes are intended.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The breaking changes are intended. The client library is still in preview https://github.com/googleapis/google-cloud-python/tree/main/packages/google-maps-places

"GetPhotoMediaRequest",
"GetPlaceRequest",
"PhotoMedia",
"SearchNearbyRequest",
"SearchNearbyResponse",
"SearchTextRequest",
"SearchTextResponse",
"Review",
)
2 changes: 1 addition & 1 deletion packages/google-maps-places/google/maps/places/gapic_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
__version__ = "0.1.3" # {x-release-please-version}
__version__ = "0.0.0" # {x-release-please-version}
27 changes: 25 additions & 2 deletions packages/google-maps-places/google/maps/places_v1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,40 @@


from .services.places import PlacesAsyncClient, PlacesClient
from .types.attribution import AuthorAttribution
from .types.ev_charging import EVChargeOptions, EVConnectorType
from .types.fuel_options import FuelOptions
from .types.geometry import Circle
from .types.photo import Photo
from .types.place import Place, PriceLevel
from .types.places_service import Int32Range, SearchTextRequest, SearchTextResponse
from .types.places_service import (
GetPhotoMediaRequest,
GetPlaceRequest,
PhotoMedia,
SearchNearbyRequest,
SearchNearbyResponse,
SearchTextRequest,
SearchTextResponse,
)
from .types.review import Review

__all__ = (
"PlacesAsyncClient",
"AuthorAttribution",
"Circle",
"Int32Range",
"EVChargeOptions",
"EVConnectorType",
"FuelOptions",
"GetPhotoMediaRequest",
"GetPlaceRequest",
"Photo",
"PhotoMedia",
"Place",
"PlacesClient",
"PriceLevel",
"Review",
"SearchNearbyRequest",
"SearchNearbyResponse",
"SearchTextRequest",
"SearchTextResponse",
)
45 changes: 45 additions & 0 deletions packages/google-maps-places/google/maps/places_v1/gapic_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,21 @@
"grpc": {
"libraryClient": "PlacesClient",
"rpcs": {
"GetPhotoMedia": {
"methods": [
"get_photo_media"
]
},
"GetPlace": {
"methods": [
"get_place"
]
},
"SearchNearby": {
"methods": [
"search_nearby"
]
},
"SearchText": {
"methods": [
"search_text"
Expand All @@ -20,6 +35,21 @@
"grpc-async": {
"libraryClient": "PlacesAsyncClient",
"rpcs": {
"GetPhotoMedia": {
"methods": [
"get_photo_media"
]
},
"GetPlace": {
"methods": [
"get_place"
]
},
"SearchNearby": {
"methods": [
"search_nearby"
]
},
"SearchText": {
"methods": [
"search_text"
Expand All @@ -30,6 +60,21 @@
"rest": {
"libraryClient": "PlacesClient",
"rpcs": {
"GetPhotoMedia": {
"methods": [
"get_photo_media"
]
},
"GetPlace": {
"methods": [
"get_place"
]
},
"SearchNearby": {
"methods": [
"search_nearby"
]
},
"SearchText": {
"methods": [
"search_text"
Expand Down
2 changes: 1 addition & 1 deletion packages/google-maps-places/google/maps/places_v1/gapic_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
__version__ = "0.1.3" # {x-release-please-version}
__version__ = "0.0.0" # {x-release-please-version}
Loading
Loading