Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add document/field/value support. #1173

Merged
merged 9 commits into from
Oct 12, 2015
Merged

Add document/field/value support. #1173

merged 9 commits into from
Oct 12, 2015

Commits on Oct 8, 2015

  1. Add document/field/value support.

    @tseaver
    tseaver committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    9210830 View commit details
    Browse the repository at this point in the history

  2. One line per import. 

    Addresses:
#1173 (comment)
    @tseaver
    tseaver committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    178e9e3 View commit details
    Browse the repository at this point in the history

  3. Pass a tuple when using '%' formatting. 

    Addresses:
#1173 (comment).
    @tseaver
    tseaver committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    bcdab30 View commit details
    Browse the repository at this point in the history

  4. Expand value/field docstrings to show params, reference URL. 

    Addresses:
#1173 (comment)
    @tseaver
    tseaver committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    3d7240d View commit details
    Browse the repository at this point in the history

  5. Elaborate 'rank' usage, point to docs. 

    Addresses:
#1173 (comment)
    @tseaver
    tseaver committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    3dbb92a View commit details
    Browse the repository at this point in the history

  6. Consistency with 'Index.from_api_repr'. 

    Addresses:
#1173 (comment)
    @tseaver
    tseaver committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    89554a7 View commit details
    Browse the repository at this point in the history

  7. Name created instance 'document'. 

    Addresses:
#1173 (comment)
    @tseaver
    tseaver committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    06b828c View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2015

  1. Clarify the sense of 'rank' for documents. 

    Addresses:
https://github.com/GoogleCloudPlatform/gcloud-python/pull/1173/files#r41574680
    @tseaver
    tseaver committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    c5c89f4 View commit details
    Browse the repository at this point in the history

  2. Explain that '**kw' arg to 'add_value' is only useful for string values. 

    Addresses:
https://github.com/GoogleCloudPlatform/gcloud-python/pull/1173/files#r41574050
    @tseaver
    tseaver committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    89f1a1e View commit details
    Browse the repository at this point in the history