Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst #1097

Merged
merged 1 commit into from
Aug 27, 2015
Merged

Update README.rst #1097

merged 1 commit into from
Aug 27, 2015

Conversation

thesandlord
Copy link
Contributor

Fixed broken link

Fixed broken link
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 26, 2015
@thesandlord
Copy link
Contributor Author

I signed it!

@thesandlord
Copy link
Contributor Author

I have a corporate CLA via Google

@dhermes
Copy link
Contributor

dhermes commented Aug 27, 2015

  1. @jgeewax What does he need to do so that googlebot recognizes him?
  2. The real fix to this is re-implementing / re-creating the broken link. This was filed as Make sure each sub-package has a landing page #1037

@jgeewax
Copy link
Contributor

jgeewax commented Aug 27, 2015

Hi @thesandlord : Check your GitHub username at (Google internal link) go/cla-signers -- it says we can't accept contributions until you click the right button... Can you give that a go? (https://cla.developers.google.com/)

@jgeewax
Copy link
Contributor

jgeewax commented Aug 27, 2015

@thesandlord : The other option is to check in the code using your @google.com e-mail address (I think).

@thesandlord
Copy link
Contributor Author

Interesting, I've contributed to Kubernetes using this account before, and they have CLA checks as well... Is this CLA bot checking email or github user? I can sign the Google CLA with my gmail if that helps.

@thesandlord
Copy link
Contributor Author

Ok, I had my gmail as the primary email on this account. I edited this file in the web UI, so it must have used my gmail. I have signed the individual CLA and switched my primary email to my @google so this should not happen again.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 27, 2015
dhermes added a commit that referenced this pull request Aug 27, 2015
@dhermes dhermes merged commit fa4563d into googleapis:master Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants