Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: PollingFuture.exception does not respect passed timeout #8733

Closed
kamilglod opened this issue Jul 23, 2019 · 1 comment · Fixed by #8735
Closed

Core: PollingFuture.exception does not respect passed timeout #8733

kamilglod opened this issue Jul 23, 2019 · 1 comment · Fixed by #8735
Assignees
@tseaver
Labels
api: core priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@kamilglod
Copy link

Environment details

  1. OS type and version: Docker, ubuntu 18.04
  2. Python version and virtual environment information: Python 3.7.1
  3. google-cloud-bigquery version: google-cloud-bigquery==1.9.0

Steps to reproduce

  1. When you e.g. run QueryJob.exception(timeout=1) it will run until job is done not respecting passed timeout, in the code

    google-cloud-python/api_core/google/api_core/future/polling.py

    Line 142 in 951b9c6

    self._blocking_poll()
    you can see that timeout argument is not passed to self._blocking_poll() as it is done in self.result(). Question is whether it is a bug or it is intentional?
@kamilglod kamilglod changed the title Core: PollingFuture.exception does not respect passed timeout Core: PollingFuture.exception does not respect passed timeout Jul 23, 2019
@tseaver tseaver added api: core priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 23, 2019
@tseaver tseaver self-assigned this Jul 23, 2019
@tseaver
Copy link
Contributor

tseaver commented Jul 23, 2019

@kamilglod Thanks for the report!

@tseaver tseaver mentioned this issue Jul 23, 2019
Merged
tseaver added a commit that referenced this issue Jul 24, 2019
@tseaver
Forward 'timeout' arg from 'exception' to '_blocking_poll'. (#8735)
f30c4de 
Closes #8733.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: core priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API Core: Forward 'timeout' arg from 'exception' to '_blocking_poll'.
2 participants
@tseaver @kamilglod