Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I write code that talks to two different datasets with two different sets of credentials? #659

Closed
jgeewax opened this issue Feb 17, 2015 · 6 comments
Assignees
Labels
api: datastore Issues related to the Datastore API. type: question Request for information or clarification. Not an issue.

Comments

@jgeewax
Copy link
Contributor

jgeewax commented Feb 17, 2015

Let's say I have:

  • /creds1.json
  • /creds2.json
  • dataset1
  • dataset2
  • gcloud.datastore

How do I pull down Person:1 from dataset1, retrieve the 'name' property, and write it back to Log:2 in dataset2?

Here's my best guess so far:

from gcloud import credentials
from gcloud import datastore

creds1 = credentials.get_for_service_account_json('/creds1.json')
creds2 = credentials.get_for_service_account_json('/creds2.json')

connection1 = datastore.Connection(credentials=creds1)
connection2 = datastore.Connection(credentials=creds1)

person1_key = datastore.Key('Person', 1, dataset_id='dataset1')
log2_key = datastore.Key('Log', 2, dataset_id='dataset2')

person1 = datastore.get(datastore.Key(person1_key), connection=connection1, dataset_id='dataset1')
log2 = datastore.get(datastore.Key(log2_key), connection=connection2, dataset_id='dataset2')

log2['data'] = person1['name']
datastore.put(log2, connection=connection2, dataset_id='dataset2')

I only got that by digging through tons of code. It made me sad.

What I want to write:

from gcloud.datastore import get_connection

dataset1 = get_connection(credentials_json='/creds1.json').get_dataset('dataset1')
dataset2 = get_connection(credentials_json='/creds2.json').get_dataset('dataset2')

person1 = dataset1.get('Person', 1)
log2 = dataset2.get('Log', 2)

log2['data'] = person1['name']
log2.put()

It seems that somewhere along the way, we lost the "hierarchy" of high-level concepts (Datastore -> Connection -> Dataset -> Entity) so that things don't seem to know who their "parent" is in the tree on the way up.

This means things like dataset.get() because it needs to be provided it's connection and credentials. It seems we've tried to overcome this by storing defaults, but that blows up when you have more than one set of credentials...

Maybe I'm totally misunderstanding?


I'm thinking that it'd be cool if we could allow three things:

  1. datastore. that accepts all the parameters to be absurdly specific (here is the connection, here is the dataset_it, etc)
  2. datastore. that has lots of Nones as default parameters, and we "go get the default" if you left it as None (ie, connection=None -> get_default_connection())
  3. Datastore -> Connection -> Dataset -> Entity drill down that "pre-fills" these things going up the chain. That is, I can say:
connection = datastore.get_connection(...)
dataset = connection.get_dataset(...)
entity = dataset.get(...)

This means that the datastore module, Connection, and Dataset all would likely have the same methods, just with fewer things you can specify because some of those fieldsare specified when you "ask for" the next level down (ie, a Dataset knows it's dataset_id, so you don't have an option to provide that) .


Example

datastore.py:

def get(key, connection=None, dataset_id=None):
  connection = connection or get_default_connection()
  dataset_id = dataset_id or get_default_dataset_id()

# Means I can do: datastore.get(Key('Person', 1), dataset_id='dataset1')

dataset.py:

class Dataset(object):

  def __init__(self, dataset_id, connection=None):
    self.dataset_id = dataset_id
    self.connection = connection

  def get(self, key):
    return datastore.get(key, dataset_id=self.dataset_id, connection=self.connection)

/cc @pcostell @dhermes @tseaver

@jgeewax jgeewax added api: datastore Issues related to the Datastore API. type: question Request for information or clarification. Not an issue. labels Feb 17, 2015
@jgeewax jgeewax added this to the Datastore Stable milestone Feb 17, 2015
@dhermes
Copy link
Contributor

dhermes commented Feb 17, 2015

@jgeewax I'm working on documenting this in a branch:
https://github.com/dhermes/gcloud-python/tree/add-gcloud-auth-docs


This is easy to do currently, as your first code snippet shows.

Let's not lose sight of the fact that

  1. very few users will ever talk to multiple datasets simultaneously or require multiple connections
  2. auth code is "one and done", so reducing your snippet from 6 lines to 8 lines is not really that meaningful when the actual code would be more like an entire code base and the auth code will still be just 4 lines

I think "bundling" defaults via an Environment is a good concept (somewhat back to a Dataset) but not one an average user should be worried with. (More like 99% of users than average.)


We had a massive discussion before (were you not cc'ed?):
https://docs.google.com/document/d/1xKw8Tz6lfN5uOcv0my4uUgFSeDoRzwCLho2UGlBpqDU/edit

Part of the removal of Dataset was also the removal of all the factory methods like Connection.get_dataset, Connection.query, etc.

The Dataset class was really just a string with factory methods.

The philosophy behind this was

If we need factory methods, our constructors need more work.

and also in the spirit of being idiomatic Python (https://www.python.org/dev/peps/pep-0020/)

There should be one-- and preferably only one --obvious way to do it.

@jgeewax
Copy link
Contributor Author

jgeewax commented Feb 17, 2015

This is easy to do currently, as your first code snippet shows.

I ... really do not think what I wrote was easy. :(

very few users will ever talk to multiple datasets simultaneously or require multiple connection

This will become less and less true over time. Right now people are tossing everything into "their datastore" because there was .. only one "datastore" (from google.appengine.ext import db). That is not going to be the case anymore, people will want to store certain data in certain regions and be able to pull from their US-based region, and put that data in their European region...

This certainly won't be "the most common thing", but I don't think that changes much.


We had a massive discussion before (were you not cc'ed?):

and

If we need factory methods, our constructors need more work.

I definitely wasn't ... and I disagree...

DI works really well when you don't need to change something mid-flight in the dependency chain (ie, if you only ever need one connection, one set of credentials, one dataset at a time). If you need to change one piece, you have to manually create the entire dependency chain and put the final product into the function call. That sucks.

Since we do need to support multiple dependency chains in the same code at the same time... I think we need concepts to help craft all of that.

There should be one-- and preferably only one --obvious way to do it.

I agree. I don't think this breaks with that. (I'm saying these aren't the same "it" -- these are two different things, each with their own obvious way to do them.)

If you need to store data (one set of credentials, one dataset, one project) the obvious way is datastore.put().

If you need to interact with multiple datasets, use multiple sets of credentials, or multiple connections, the obvious way is to drill down and create things that you need.

@dhermes
Copy link
Contributor

dhermes commented Feb 17, 2015

Most important thing which we can all agree on

If you need to change one piece, you have to manually create the entire dependency chain and
put the final product into the function call. That sucks.

@tseaver tseaver self-assigned this Feb 17, 2015
@tseaver
Copy link
Contributor

tseaver commented Feb 18, 2015

@jgeewax does the merge of #660 close this issue?

@jgeewax
Copy link
Contributor Author

jgeewax commented Feb 19, 2015

Yep -- I may double check that we can do the multiple credentials thing, but I'll resolve and open a different issue for that if not.

@jgeewax jgeewax closed this as completed Feb 19, 2015
@tseaver
Copy link
Contributor

tseaver commented Feb 19, 2015

vchudnov-g pushed a commit that referenced this issue Sep 20, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/0ddbff8012e47cde4462fe3f9feab01fbc4cdfd6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b
parthea pushed a commit that referenced this issue Oct 21, 2023
* Add new "quickstart" samples [(#547)](GoogleCloudPlatform/python-docs-samples#547)

* Quickstart tests [(#569)](GoogleCloudPlatform/python-docs-samples#569)

* Add tests for quickstarts
* Update secrets

* Add translate samples [(#574)](GoogleCloudPlatform/python-docs-samples#574)

* Generate most non-appengine readmes

Change-Id: I3779282126cdd05b047194d356932b9995484115

* Update requirements.txt

* added model in the sample [(#650)](GoogleCloudPlatform/python-docs-samples#650)

* added with and without model separately [(#657)](GoogleCloudPlatform/python-docs-samples#657)

* Translate API no longer requires an API key. [(#659)](GoogleCloudPlatform/python-docs-samples#659)

* Auto-update dependencies. [(#715)](GoogleCloudPlatform/python-docs-samples#715)

* Changes default model to premium [(#749)](GoogleCloudPlatform/python-docs-samples#749)

* Updates readme template to show credential auth instead of api key. [(#802)](GoogleCloudPlatform/python-docs-samples#802)

* Updates translate version to match speech and language. [(#843)](GoogleCloudPlatform/python-docs-samples#843)

* Translate update [(#886)](GoogleCloudPlatform/python-docs-samples#886)

* Remove cloud config fixture [(#887)](GoogleCloudPlatform/python-docs-samples#887)

* Remove cloud config fixture

* Fix client secrets

* Fix bigtable instance

* Unicode for translation

* Adds check for translated text

* Unicode for translation

* Unicode for translation

* Unicode for translation

* missing newline

* Adds six for 2/3 compatibility

* Changes encoding style.

* Fix unicode

* renaming of the product to Google Translation API [(#910)](GoogleCloudPlatform/python-docs-samples#910)

* Update translate readme

* Re-generate all readmes

* Fix README rst links [(#962)](GoogleCloudPlatform/python-docs-samples#962)

* Fix README rst links

* Update all READMEs

* Auto-update dependencies. [(#1004)](GoogleCloudPlatform/python-docs-samples#1004)

* Auto-update dependencies.

* Fix natural language samples

* Fix pubsub iam samples

* Fix language samples

* Fix bigquery samples

* Auto-update dependencies. [(#1055)](GoogleCloudPlatform/python-docs-samples#1055)

* Auto-update dependencies.

* Explicitly use latest bigtable client

Change-Id: Id71e9e768f020730e4ca9514a0d7ebaa794e7d9e

* Revert language update for now

Change-Id: I8867f154e9a5aae00d0047c9caf880e5e8f50c53

* Remove pdb. smh

Change-Id: I5ff905fadc026eebbcd45512d4e76e003e3b2b43

* Auto-update dependencies. [(#1093)](GoogleCloudPlatform/python-docs-samples#1093)

* Auto-update dependencies.

* Fix storage notification poll sample

Change-Id: I6afbc79d15e050531555e4c8e51066996717a0f3

* Fix spanner samples

Change-Id: I40069222c60d57e8f3d3878167591af9130895cb

* Drop coverage because it's not useful

Change-Id: Iae399a7083d7866c3c7b9162d0de244fbff8b522

* Try again to fix flaky logging test

Change-Id: I6225c074701970c17c426677ef1935bb6d7e36b4

* Update all generated readme auth instructions [(#1121)](GoogleCloudPlatform/python-docs-samples#1121)

Change-Id: I03b5eaef8b17ac3dc3c0339fd2c7447bd3e11bd2

* Added Link to Python Setup Guide [(#1158)](GoogleCloudPlatform/python-docs-samples#1158)

* Update Readme.rst to add Python setup guide

As requested in b/64770713.

This sample is linked in documentation https://cloud.google.com/bigtable/docs/scaling, and it would make more sense to update the guide here than in the documentation.

* Update README.rst

* Update README.rst

* Update README.rst

* Update README.rst

* Update README.rst

* Update install_deps.tmpl.rst

* Updated readmegen scripts and re-generated related README files

* Fixed the lint error

* Auto-update dependencies. [(#1186)](GoogleCloudPlatform/python-docs-samples#1186)

* Fixed failed tests on Kokoro (Spanner + Translate) [(#1192)](GoogleCloudPlatform/python-docs-samples#1192)

* Fixed failed tests on Kokoro (Spanner + Translate)

* Update quickstart_test.py

* Added "Open in Cloud Shell" buttons to README files [(#1254)](GoogleCloudPlatform/python-docs-samples#1254)

* Auto-update dependencies. [(#1377)](GoogleCloudPlatform/python-docs-samples#1377)

* Auto-update dependencies.

* Update requirements.txt

* Regenerate the README files and fix the Open in Cloud Shell link for some samples [(#1441)](GoogleCloudPlatform/python-docs-samples#1441)

* Update READMEs to fix numbering and add git clone [(#1464)](GoogleCloudPlatform/python-docs-samples#1464)

* Add translate region tags [(#1488)](GoogleCloudPlatform/python-docs-samples#1488)

* Add region tags

* Added end region tags

* Linting errors fixed

* Include the comma in the translation [(#1787)](GoogleCloudPlatform/python-docs-samples#1787)

* Auto-update dependencies. [(#1980)](GoogleCloudPlatform/python-docs-samples#1980)

* Auto-update dependencies.

* Update requirements.txt

* Update requirements.txt

* Translation v3beta1 samples [(#2084)](GoogleCloudPlatform/python-docs-samples#2084)

* Add in progress beta snippets

Change-Id: I2cd8ddc2307a8e40d56ce7e493749dc05c34d164

* Add google-cloud-storage dependency

Change-Id: Iff7bc9b2c82b1e829580a3d4ad628087dbeee8be

* Non-'global' location required for BatchTranslateText

Change-Id: I5198aa6368a088e8f5ee295dc55a5e9e4ca8f494

* Upgrade google-cloud-translate to 1.4.0

1.4.0 includes the new v3beta1 alongside V2

Change-Id: I5adfe78ea7e78d84678db343cd84516e3d05491f

* Update Translate samples

You can now provide your own glossary ID

The tests now run within a randomly created bucket (deleted after each
test)

Change-Id: I5cb2680cd0e9e43c85932a6a0dc19e6fab5008c5

* pytest.fixture for random test bucket

Change-Id: I8e816ed4c95a6235347a29849044b4cab02d40a8

* flake8 spec fixes

Change-Id: I4932bcf856a9498b01d9661c90c6b45ee2958ee1

* Added pytest fixture for creating glossary (WIP)

Change-Id: Iddb5ecbf0eefb9efd2243dc4bc56b585102e9351

* Add assertions, remove placeholder TODOs

Change-Id: If1eb20bca5bfcc87dd0652d5488b2188afa626af

* fixing translate-with-glossary bug [(#2323)](GoogleCloudPlatform/python-docs-samples#2323)

* Translate beta samples fix [(#2327)](GoogleCloudPlatform/python-docs-samples#2327)

* fixing translate-with-glossary bug

* tests passing

* reverting to python3 compatibility

* snippets test fix

* Using glossaries with tts and vision tutorial sample code [(#2325)](GoogleCloudPlatform/python-docs-samples#2325)

* fixing translate-with-glossary bug

* initial commit

* adding resources

* adding more resources

* glossary accomodates upper case words

* finished hybrid glossaries tutorial sample code

* Revert "fixing translate-with-glossary bug"

This reverts commit 6a9f7ca3f68239a862106fcbcd9c73649ce36c77.

* lint fix for tests. TODO src lint fix

* lint

* it's the final lint-down

* adding README

* implementing @nnegrey's feedback

* lint

* lint

* extracting files from cloud-client

* lint comment test

* fixing comments per @beccasaurus

* removing redundant directory

* implementing @nnegrey's feedback

* lint

* lint

* handling glossary-already-exists exception

* lint

* adding ssml functionality

* fixing imports per @nnegrey

* fixed import comment

* more specific exceptions import

* removing period from copyright

* fix: refactored MP3 file creation test for Hybrid glossaries samples [(#2379)](GoogleCloudPlatform/python-docs-samples#2379)

* fix: refactored MP3 file creation test

* fix: lint

* Fix variable names in comments [(#2400)](GoogleCloudPlatform/python-docs-samples#2400)

* Adds updates for samples profiler ... vision [(#2439)](GoogleCloudPlatform/python-docs-samples#2439)

* Update v2 samples to explicitly use v2 library [(#2498)](GoogleCloudPlatform/python-docs-samples#2498)

* fix: translate test [(#2671)](GoogleCloudPlatform/python-docs-samples#2671)

* fix: translate test

* Add unicode formatting

* automl: add natural language sentiment analysis ga samples [(#2677)](GoogleCloudPlatform/python-docs-samples#2677)

* automl: add natural language sentiment analysis ga samples

* Add links to documentation

* Update tests to use centralized project

* Fix environment variable, make translate test less flaky

* fix region tag typo [(#2731)](GoogleCloudPlatform/python-docs-samples#2731)

* Migrate published samples [(#2759)](GoogleCloudPlatform/python-docs-samples#2759)

Migrate from tmp-generated-samples branch 615c08e
Remove boilerplate
Update copyright date
Blacken
Remove unused imports
Shorten docstrings
Remove CLI
Set defaults in function definition
Add link to supported types guide
Inline function arguments
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>

* translate v3 snippets [(#2745)](GoogleCloudPlatform/python-docs-samples#2745)

* translate text v3

* added translate text with glossary snippets

* finished glossary tests

* removed overlapping files

* added encoding tag

* added more descriptive docs and broke down tests

* Update translate/cloud-client/translate_v3_create_glossary.py

Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>

* Update translate/cloud-client/translate_v3_create_glossary.py

Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>

* fixed test for translate with glossary

* fixed lint

Co-authored-by: Michelle Casbon <texasmichelle@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>

* Translate: migrate published samples [(#2768)](GoogleCloudPlatform/python-docs-samples#2768)

Migrate from tmp-generated-samples branch 615c08e
Remove boilerplate
Update copyright date
Blacken
Remove unused imports

* Translate: migrate published glossaries samples [(#2769)](GoogleCloudPlatform/python-docs-samples#2769)

Migrate from tmp-generated-samples branch fef998b
Remove boilerplate
Update copyright date
Blacken
Remove unused imports
Shorten docstrings
Remove CLI

* translate: increase timeout [(#2937)](GoogleCloudPlatform/python-docs-samples#2937)

* Translate: migrate published  v3 translate batch samples [(#2914)](GoogleCloudPlatform/python-docs-samples#2914)

* Translate: migrate published b v3 tch samples

* added missing requirements

* extended wait time

* inlined some vals and specified input and output

* added link to supported file types & modified default values of input uri

* fixed small nit

* chore(deps): update dependency google-cloud-storage to v1.26.0 [(#3046)](GoogleCloudPlatform/python-docs-samples#3046)

* chore(deps): update dependency google-cloud-storage to v1.26.0

* chore(deps): specify dependencies by python version

* chore: up other deps to try to remove errors

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Co-authored-by: Leah Cole <coleleah@google.com>

* chore(deps): update dependency google-cloud-translate to v1.7.0 [(#3084)](GoogleCloudPlatform/python-docs-samples#3084)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [google-cloud-translate](https://togithub.com/googleapis/python-translate) | minor | `==1.6.0` -> `==1.7.0` |

---

### Release Notes

<details>
<summary>googleapis/python-translate</summary>

### [`v1.7.0`](https://togithub.com/googleapis/python-translate/blob/master/CHANGELOG.md#&#8203;170)

[Compare Source](https://togithub.com/googleapis/python-translate/compare/v1.6.0...v1.7.0)

10-07-2019 14:57 PDT

##### Implementation Changes

-   Update docstrings, client confg (via synth). ([#&#8203;9411](https://togithub.com/googleapis/google-cloud-python/pull/9411))
-   Remove send / receive message size limit (via synth). ([#&#8203;8974](https://togithub.com/googleapis/google-cloud-python/pull/8974))

##### New Features

-   Add support for V3 of the API. ([#&#8203;9020](https://togithub.com/googleapis/google-cloud-python/pull/9020))
-   Make `parent` argument required for all client methods in v3beta1; add `labels` argument (via synth). ([#&#8203;9354](https://togithub.com/googleapis/google-cloud-python/pull/9354))
-   Add client options to translate_v2. ([#&#8203;8737](https://togithub.com/googleapis/google-cloud-python/pull/8737))

##### Dependencies

-   Bump minimum version for google-api-core to 1.14.0. ([#&#8203;8709](https://togithub.com/googleapis/google-cloud-python/pull/8709))

##### Documentation

-   Fix links to reference documentation. ([#&#8203;8884](https://togithub.com/googleapis/google-cloud-python/pull/8884))
-   Link to googleapis.dev documentation in READMEs. ([#&#8203;8705](https://togithub.com/googleapis/google-cloud-python/pull/8705))

##### Internal / Testing Changes

-   Update `ListGlossaries` method annotation (via synth)  ([#&#8203;9385](https://togithub.com/googleapis/google-cloud-python/pull/9385))
-   Fix intersphinx reference to requests ([#&#8203;9294](https://togithub.com/googleapis/google-cloud-python/pull/9294))
-   Remove CI for gh-pages, use googleapis.dev for api_core refs. ([#&#8203;9085](https://togithub.com/googleapis/google-cloud-python/pull/9085))
-   Update intersphinx mapping for requests. ([#&#8203;8805](https://togithub.com/googleapis/google-cloud-python/pull/8805))

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples).

* translate: fix tests [(#3087)](GoogleCloudPlatform/python-docs-samples#3087)

Fix: GoogleCloudPlatform/python-docs-samples#3018

* translate-v3:  samples [(#3034)](GoogleCloudPlatform/python-docs-samples#3034)

* translate with custom model, get supported langs

* inlined small nit

* added encoding to model test

* added missing region tags and link to supported langs

* inlined text-to-translate

* directly inlined contents

* revert text-translate vars

* reversed inlined text params

* small nit

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>

* chore(deps): update dependency google-cloud-vision to v0.42.0 [(#3170)](GoogleCloudPlatform/python-docs-samples#3170)

* chore(deps): update dependency google-cloud-texttospeech to v1 [(#3210)](GoogleCloudPlatform/python-docs-samples#3210)

Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>

* chore(deps): update dependency google-cloud-translate to v2 [(#3211)](GoogleCloudPlatform/python-docs-samples#3211)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [google-cloud-translate](https://togithub.com/googleapis/python-translate) | major | `==1.7.0` -> `==2.0.1` |

---

### Release Notes

<details>
<summary>googleapis/python-translate</summary>

### [`v2.0.1`](https://togithub.com/googleapis/python-translate/blob/master/CHANGELOG.md#&#8203;201-httpswwwgithubcomgoogleapispython-translatecomparev200v201-2020-01-31)

[Compare Source](https://togithub.com/googleapis/python-translate/compare/v2.0.0...v2.0.1)

### [`v2.0.0`](https://togithub.com/googleapis/python-translate/blob/master/CHANGELOG.md#&#8203;200)

[Compare Source](https://togithub.com/googleapis/python-translate/compare/v1.7.0...v2.0.0)

10-23-2019 11:13 PDT

##### New Features

-   Make v3 the default client. ([#&#8203;9498](https://togithub.com/googleapis/google-cloud-python/pull/9498))

##### Internal / Testing Changes

-   Add VPC-SC system tests. ([#&#8203;9272](https://togithub.com/googleapis/google-cloud-python/pull/9272))

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples).

* Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-samples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Update dependency google-cloud-vision to v1 [(#3227)](GoogleCloudPlatform/python-docs-samples#3227)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [google-cloud-vision](https://togithub.com/googleapis/python-vision) | major | `==0.42.0` -> `==1.0.0` |

---

### Release Notes

<details>
<summary>googleapis/python-vision</summary>

### [`v1.0.0`](https://togithub.com/googleapis/python-vision/blob/master/CHANGELOG.md#&#8203;100-httpswwwgithubcomgoogleapispython-visioncomparev0420v100-2020-02-28)

[Compare Source](https://togithub.com/googleapis/python-vision/compare/v0.42.0...v1.0.0)

##### Features

-   bump release status to GA ([#&#8203;11](https://www.github.com/googleapis/python-vision/issues/11)) ([2129bde](https://www.github.com/googleapis/python-vision/commit/2129bdedfa0dca85c5adc5350bff10d4a485df77))

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples).

* translate: make test generic [(#3386)](GoogleCloudPlatform/python-docs-samples#3386)

Fix: GoogleCloudPlatform/python-docs-samples#3381

* [translate] fix: mark some tests as flaky [(#3495)](GoogleCloudPlatform/python-docs-samples#3495)

tests which involve LRO.

fixes #2875

* testing: replace @flaky with @pytest.mark.flaky [(#3496)](GoogleCloudPlatform/python-docs-samples#3496)

* testing: replace @flaky with @pytest.mark.flaky

* lint

* mark few tests as flaky

that involves LRO polling.

* lint

* chore(deps): update dependency google-cloud-storage to v1.28.0 [(#3260)](GoogleCloudPlatform/python-docs-samples#3260)

Co-authored-by: Takashi Matsuo <tmatsuo@google.com>

* translate: fix glossary leak issue [(#3572)](GoogleCloudPlatform/python-docs-samples#3572)

* fix glossary leak issue

* removed try/catch from teardown methods, removed sample_ prefix from all other methods

* added specific exceptions to tests, added backoff tags to tests

* fixed the lint issues

* reordered imports

* moved backoff inside methd and removed Retry

* corrected import nit

* chore: some lint fixes [(#3751)](GoogleCloudPlatform/python-docs-samples#3751)

* chore: some lint fixes

* longer timeout, more retries

* disable detect_test.py::test_async_detect_document

* chore(deps): update dependency google-cloud-storage to v1.28.1 [(#3785)](GoogleCloudPlatform/python-docs-samples#3785)

* chore(deps): update dependency google-cloud-storage to v1.28.1

* [asset] testing: use uuid instead of time

Co-authored-by: Takashi Matsuo <tmatsuo@google.com>

* [translate] fix hybrid glossaries tests [(#3936)](GoogleCloudPlatform/python-docs-samples#3936)

* testing: start using btlr [(#3959)](GoogleCloudPlatform/python-docs-samples#3959)

* testing: start using btlr

The binary is at gs://cloud-devrel-kokoro-resources/btlr/v0.0.1/btlr

* add period after DIFF_FROM

* use array for btlr args

* fix websocket tests

* add debug message

* wait longer for the server to spin up

* dlp: bump the wait timeout to 10 minutes

* [run] copy noxfile.py to child directory to avoid gcloud issue

* [iam] fix: only display description when the key exists

* use uuid4 instead of uuid1

* [iot] testing: use the same format for registry id

* Stop asserting Out of memory not in the output

* fix missing imports

* [dns] testing: more retries with delay

* [dlp] testing: longer timeout

* use the max-concurrency flag

* use 30 workers

* [monitoring] use multiple projects

* [dlp] testing: longer timeout

* Replace GCLOUD_PROJECT with GOOGLE_CLOUD_PROJECT. [(#4022)](GoogleCloudPlatform/python-docs-samples#4022)

* remove whitelist replace with allowlist [(#4050)](GoogleCloudPlatform/python-docs-samples#4050)

* chore(deps): update dependency google-cloud-storage to v1.29.0 [(#4040)](GoogleCloudPlatform/python-docs-samples#4040)

* chore(deps): update dependency google-cloud-texttospeech to v2.1.0 [(#4147)](GoogleCloudPlatform/python-docs-samples#4147)

* testing(translate): parameterize the timeout [(#4247)](GoogleCloudPlatform/python-docs-samples#4247)

fixes #4239
(by specifying a longer timeout)

* chore(deps): update dependency pytest to v5.4.3 [(#4279)](GoogleCloudPlatform/python-docs-samples#4279)

* chore(deps): update dependency pytest to v5.4.3

* specify pytest for python 2 in appengine

Co-authored-by: Leah Cole <coleleah@google.com>

* Update dependency flaky to v3.7.0 [(#4300)](GoogleCloudPlatform/python-docs-samples#4300)

* testing(translate): bump the timeout for operations [(#4258)](GoogleCloudPlatform/python-docs-samples#4258)

fixes #4220

* chore: update templates

* chore: narrows samples CODEOWNERS to .py only

* chore: wip migration to microgenerator
client, units, docs complete

* feat!: move API to python microgenerator

* docs: readmegen updates

* chore: add build config for docs-presubmit

* chore: rm protos

* chore: uses PROJECT_ID env var in system test

* chore: clarifies examples in migration guide

* chore: adds explicit variable

Co-authored-by: Jason Dobry <jmdobry@users.noreply.github.com>
Co-authored-by: Jon Wayne Parrott <jonwayne@google.com>
Co-authored-by: Puneith Kaul <puneith@users.noreply.github.com>
Co-authored-by: DPE bot <dpebot@google.com>
Co-authored-by: Gus Class <gguuss@gmail.com>
Co-authored-by: florencep <florenceperot@google.com>
Co-authored-by: Bill Prin <waprin@gmail.com>
Co-authored-by: michaelawyu <chenyumic@google.com>
Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Co-authored-by: Averi Kitsch <akitsch@google.com>
Co-authored-by: Charles Engelke <github@engelke.com>
Co-authored-by: Rebecca Taylor <remilytaylor@gmail.com>
Co-authored-by: Elizabeth Crowdus <elcrowdus@gmail.com>
Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Co-authored-by: Michelle Casbon <texasmichelle@users.noreply.github.com>
Co-authored-by: Mike <45373284+munkhuushmgl@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-authored-by: WhiteSource Renovate <bot@renovateapp.com>
Co-authored-by: Leah Cole <coleleah@google.com>
Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

3 participants