-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(google-cloud-vision) enum34 should not be installed on Python 3.4+ #3398
Comments
@matrixl Can you link to the known issue? Our unit tests run in Python 3.4, 3.5, 3.6 and our system tests run in 3.6 without any issue at all. |
Here is the issue reported in other project. Also some discussion over here. |
Both of this indicate that the incompatibility was resolved 2 years ago. Am I somehow misreading? |
Yes, those issues have been fixed, but the way they fixed it is to only install enum34 with Python < 3.4. Here is the latest post in 2017.
It was tagged as "WONTFIX", so the only way to fix it is to only require it with Python < 3.4 |
Gotcha, thanks for digging @matrixl. So the issue isn't that our code is broken on it's own, just that it steps in front of @jonparrott WDYT of adding |
@dhermes I'm fine with that. |
@matrixl If what you report is true, I don't understand how our system and unit tests could be working with |
@tseaver He didn't say it doesn't work with our code, he said: "enum34 breaks my code (python3.6)". The point is that |
The enum34 breaks my code (python3.6), it is a known issue that enum34 doesn't work on Python 3.4+
Please refer to the discussion over here:
https://bitbucket.org/stoneleaf/enum34/issues/5/enum34-incompatible-with-python-35#comment-19462547
suggested fix in vision/setup.py
The text was updated successfully, but these errors were encountered: