Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make storage ACL objects handle lazy loading and remove get_acl() from Key / Bucket #338

Closed
dhermes opened this issue Nov 4, 2014 · 3 comments
Closed

Make storage ACL objects handle lazy loading and remove get_acl() from Key / Bucket #338

dhermes opened this issue Nov 4, 2014 · 3 comments
Assignees
@tseaver
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
Storage Stable

Comments

@dhermes
Copy link
Contributor

dhermes commented Nov 4, 2014

See #333
@dhermes dhermes added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the Cloud Storage API. labels Nov 4, 2014
@dhermes dhermes self-assigned this Nov 4, 2014
@dhermes dhermes mentioned this issue Nov 4, 2014
Merged
@dhermes
Copy link
Contributor Author

dhermes commented Nov 4, 2014

Toying with a decorator on methods which require lazy loading.

Leaning against it since

Currently wrestling tests. They are a bit brittle in the sense that Monkey objects rely on side-affects that don't happen when get_acl() is removed.

@tseaver
Copy link
Contributor

tseaver commented Nov 13, 2014

Would you like me to make a stab at this one? I had a notion about how it would be implemented when we first discussed it (but I'll have to reconstruct it now).

@dhermes
Copy link
Contributor Author

dhermes commented Nov 13, 2014

I actually started working on this:
https://github.com/dhermes/gcloud-python/tree/make-acl-handle-lazy-load

The key issue I ran into was that some of the tests don't want / need the ACL to be loaded.

See dhermes@9027140 for a first-pass (tests don't all pass).

@tseaver Go ahead and take a stab at it, I just don't have the cycles over the next few days.

@dhermes dhermes assigned tseaver and unassigned dhermes Nov 13, 2014
tseaver added a commit that referenced this issue Nov 13, 2014
@tseaver
Merge pull request #373 from tseaver/338-make_acl_lazy_load-remove_ge…
9d6efcf 
…t_acl

Fix #338: make 'acl' lazy load, remove 'get-acl()'
@jgeewax jgeewax modified the milestone: Storage Stable Jan 30, 2015
atulep pushed a commit that referenced this issue Apr 6, 2023
@renovate-bot
chore(deps): update dependency google-cloud-speech to v2.13.1 (#338)
d2f67d0
atulep pushed a commit that referenced this issue Apr 6, 2023
@renovate-bot
chore(deps): update dependency google-cloud-speech to v2.13.1 (#338)
b60678e
atulep pushed a commit that referenced this issue Apr 18, 2023
@renovate-bot
chore(deps): update dependency google-cloud-speech to v2.13.1 (#338)
65c48e6
parthea added a commit that referenced this issue Jun 4, 2023
@renovate-bot @gcf-owl-bot
@galz10 @parthea
chore(deps): update all dependencies (#338)
f8339a9 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.2 (#338)
cee1a25 
* chore: Update gapic-generator-python to v1.8.2

PiperOrigin-RevId: 504289125

Source-Link: googleapis/googleapis@38a48a4

Source-Link: googleapis/googleapis-gen@b2dc226
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
docs: update taxonomy display_name comment (#338)
ac69219 
- [ ] Regenerate this pull request now.

feat: added Dataplex specific fields
feat: AuditConfig for IAM v1
fix(deps): require grpc-google-iam-v1 >=0.12.4
docs: fix type in docstring for map fields 

PiperOrigin-RevId: 440386238

Source-Link: googleapis/googleapis@99fd8be

Source-Link: googleapis/googleapis-gen@e132e73
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTEzMmU3M2U1MTRlZDdhMzAwOWU2OWRlODI0OGEzNjRiODg3OGNiOCJ9
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
build(deps): bump cryptography from 38.0.3 to 39.0.1 in /synthtool/gc…
f7e0112 
…p/templates/python_library/.kokoro (#338)

Source-Link: https://togithub.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
build(deps): bump requests to 2.31.0 [autoapprove] (#338)
7d2a7f2 
Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b
parthea added a commit that referenced this issue Jun 4, 2023
@dandhlee @parthea
docs: fix changelog header to consistent size (#338)
0a48c1d 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Sep 20, 2023
@renovate-bot
chore(deps): update dependency google-cloud-retail to v1.10.0 (#338)
4b04ec8
vchudnov-g pushed a commit that referenced this issue Sep 20, 2023
@gcf-owl-bot
build(python): remove python 3.7 from kokoro Dockerfile (#338)
35977c0 
Source-Link: googleapis/synthtool@e44dc0c
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:5ff7446edeaede81c3ed58b23a4e76a5403fba1350ce28478045657303b6479d
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
build: [autoapprove] bump cryptography from 41.0.2 to 41.0.3 (#338)
9dcb131 
Source-Link: https://togithub.com/googleapis/synthtool/commit/352b9d4c068ce7c05908172af128b294073bf53c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
build(deps): bump cryptography from 38.0.3 to 39.0.1 in /synthtool/gc…
2b1c8e2 
…p/templates/python_library/.kokoro (#338)

Source-Link: https://togithub.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf
parthea added a commit that referenced this issue Sep 22, 2023
@renovate-bot @parthea
chore(deps): update dependency google-cloud-container to v2.17.1 (#338)
9034751 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@renovate-bot
chore(deps): update all dependencies (#338)
48cd9d1
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
chore(deps): update actions/checkout action to v3 (#338)
5a3f383 
Source-Link: googleapis/synthtool@ca87909
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6162c384d685c5fe22521d3f37f6fc732bf99a085f6d47b677dbcae97fc21392
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
chore: remove pinned Sphinx version [autoapprove] (#338)
3a19f05 
Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
parthea pushed a commit that referenced this issue Sep 22, 2023
@release-please
chore(main): release 2.13.0 (#338)
02a0b0e 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this issue Sep 22, 2023
@parthea
fix(deps): allow protobuf 3.19.5 (#338)
3c99250 
* fix(deps): allow protobuf 3.19.5

* explicitly exclude protobuf 4.21.0
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-resource-manager to v1.3.3 (
9054792 
#338)
parthea pushed a commit that referenced this issue Oct 21, 2023
@release-please
chore(main): release 1.5.2 (#338)
a9ed101 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-pubsub to v2.13.10 (#338)
e35437a
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.3 (#338)
1d2dad6
parthea added a commit that referenced this issue Oct 21, 2023
@release-please @parthea
chore(main): release 3.7.1 (#338)
b0c3037 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this issue Oct 21, 2023
@renovate-bot @parthea
chore(deps): update dependency pillow to v9.1.0 (#338)
8124c93 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.3.1 (#338)
8e9a347
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.4 (#338)
8a572e9 
* chore: Update gapic-generator-python to v1.8.4

PiperOrigin-RevId: 507808936

Source-Link: googleapis/googleapis@64cf849

Source-Link: googleapis/googleapis-gen@53c48ca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this issue Oct 21, 2023
@parthea
fix: handle AttributeError in automl_v1beta1.TablesClient (#338)
5a2a7ad
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore: use gapic generator python 1.4.1 (#338)
d0acc7f 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 473833416

Source-Link: googleapis/googleapis@565a550

Source-Link: googleapis/googleapis-gen@1ee1a06
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9
parthea pushed a commit that referenced this issue Oct 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-speech to v2.13.1 (#338)
a94ae39
parthea added a commit that referenced this issue Oct 22, 2023
@gcf-owl-bot @parthea
chore: Update gapic-generator-python to v1.11.9 (#338)
3ad878f 
* chore: Update gapic-generator-python to v1.11.7

PiperOrigin-RevId: 573230664

Source-Link: googleapis/googleapis@93beed3

Source-Link: googleapis/googleapis-gen@f4a4eda
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjRhNGVkYWE4MDU3NjM5ZmNmNmFkZjkxNzk4NzIyODBkMWE4ZjY1MSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Update gapic-generator-python to v1.11.8

PiperOrigin-RevId: 574178735

Source-Link: googleapis/googleapis@7307199

Source-Link: googleapis/googleapis-gen@ce3af21
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2UzYWYyMWI3YzU1OWE4N2MyYmVmYzA3NmJlMGUzYWVkYTNhMjZmMCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Update gapic-generator-python to v1.11.9

PiperOrigin-RevId: 574520922

Source-Link: googleapis/googleapis@5183984

Source-Link: googleapis/googleapis-gen@a59af19
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTU5YWYxOWQ0YWM2NTA5ZmFlZGYxY2MzOTAyOTE0MWI2YTViODk2OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* update post processor image; remove unused files

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
Storage Stable
Development

No branches or pull requests
3 participants
@jgeewax @tseaver @dhermes