Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove time.sleep in Speech system tests. #3273

Closed
lukesneeringer opened this issue Apr 5, 2017 · 1 comment
Closed

Remove time.sleep in Speech system tests. #3273

lukesneeringer opened this issue Apr 5, 2017 · 1 comment
Assignees
@lukesneeringer
Labels
api: speech Issues related to the Speech-to-Text API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: blocked Resolving the issue is dependent on other work.

Comments

@lukesneeringer
Copy link
Contributor

The Speech system tests contain defensive code to address a backend issue with the new v1 endpoint (it sometimes returns v1beta1 LRO URLs).

This is supposed to be fixed in the backend soon; remove the defensive code once it is.
@lukesneeringer lukesneeringer added api: speech Issues related to the Speech-to-Text API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: blocked Resolving the issue is dependent on other work. labels Apr 5, 2017
@lukesneeringer lukesneeringer self-assigned this Apr 5, 2017
@lukesneeringer lukesneeringer mentioned this issue Apr 5, 2017
Merged
@lukesneeringer
Copy link
Contributor Author

This code is gone.

parthea pushed a commit that referenced this issue Jun 4, 2023
@munkhuushmgl @busunkim96
Talent v4beta1 samples [Restoring deleted branch samples] [(#3273)](G…
66deb64 
…oogleCloudPlatform/python-docs-samples#3273)

* restored deleted samples

* fixed lint issues

* added tests and formatted code

* corrected test req.txt file

* made requested changes and added return val for samples

* added secrets.txt to bash, script

* fixed the lint

* moved to requirements-test.txt

* delete resources in teardown just in case

* restored deleted samples

fixed lint issues

added tests and formatted code

corrected test req.txt file

made requested changes and added return val for samples

added secrets.txt to bash, script

fixed the lint

* added some spacing

* restored deleted samples

fixed lint issues

added tests and formatted code

corrected test req.txt file

made requested changes and added return val for samples

added secrets.txt to bash, script

fixed the lint

restored deleted samples

fixed lint issues

added tests and formatted code

corrected test req.txt file

made requested changes and added return val for samples

added secrets.txt to bash, script

fixed the lint

moved to requirements-test.txt

delete resources in teardown just in case

added some spacing

* fixed merge conflicts

* added conftest.py and refactored samples with loop

* removed talent secret.txt from bash script

* fixed the lint issue

* removed unnecessary env vars

* deleted global random ids, deleted unnecessary setup code from delete tests

* removed unused imports

* removed pytest

* removed unused IDs

* deleted unused uuid imports

Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukesneeringer lukesneeringer

Labels
api: speech Issues related to the Speech-to-Text API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: blocked Resolving the issue is dependent on other work.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukesneeringer