Skip to content

Commit

Permalink
Explicitly using API_BASE_URL from current connection in datastore.
Browse files Browse the repository at this point in the history
This can be seen as a bug-fix where a sub-class may not be able
to impact the URIs generated.

In addition, we added the (repeated) value of the base connection's
API_BASE_URL in advance of swapping it out for v1beta3.
  • Loading branch information
dhermes committed Dec 16, 2015
1 parent 36b08c1 commit a4b28df
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion gcloud/datastore/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ class Connection(connection.Connection):
from :mod:`gcloud.connection`.
"""

API_BASE_URL = 'https://www.googleapis.com'
"""The base of the API call URL."""

API_VERSION = 'v1beta2'
"""The version of the API, used in building the API call's URL."""

Expand All @@ -54,7 +57,7 @@ def __init__(self, credentials=None, http=None, api_base_url=None):
super(Connection, self).__init__(credentials=credentials, http=http)
if api_base_url is None:
api_base_url = os.getenv(GCD_HOST,
connection.API_BASE_URL)
self.__class__.API_BASE_URL)
self.api_base_url = api_base_url

def _request(self, dataset_id, method, data):
Expand Down

0 comments on commit a4b28df

Please sign in to comment.