chore: use gapic-generator-python 1.2.0 (#192)

* chore: use gapic-generator-python 1.2.0 PiperOrigin-RevId: 467286830 Source-Link: googleapis/googleapis@e6e875a Source-Link: googleapis/googleapis-gen@0295ea1 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDI5NWVhMTRkOWNkNGQ0N2RkYjIzYjllYmQzOWEzMWUyMDM1ZTI4ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * remove workarounds in owlbot.py; restore 100% coverge Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
googleapis · Aug 16, 2022 · 8b2ee04 · 8b2ee04
1 parent cdea04e
commit 8b2ee04
Show file tree

Hide file tree

Showing 7 changed files with 29 additions and 44 deletions.
diff --git a/packages/google-cloud-gke-hub/.coveragerc b/packages/google-cloud-gke-hub/.coveragerc
@@ -4,7 +4,7 @@ branch = True
 [report]
 show_missing = True
 omit =
-    google/cloud/gkehub/multiclusteringress/__init__.py
+    google/cloud/gkehub/__init__.py
 exclude_lines =
     # Re-enable the standard pragma
     pragma: NO COVER

diff --git a/packages/google-cloud-gke-hub/.github/workflows/unittest.yml b/packages/google-cloud-gke-hub/.github/workflows/unittest.yml
@@ -54,4 +54,4 @@ jobs:
     - name: Report coverage results
       run: |
         coverage combine .coverage-results/.coverage*
-        coverage report --show-missing --fail-under=99
+        coverage report --show-missing --fail-under=100
diff --git a/...d-gke-hub/google/cloud/gkehub_v1beta1/services/gke_hub_membership_service/async_client.py b/...d-gke-hub/google/cloud/gkehub_v1beta1/services/gke_hub_membership_service/async_client.py
@@ -1329,9 +1329,11 @@ async def set_iam_policy(
                 optionally specify a ``condition``, which is a logic
                 expression that further constrains the role binding
                 based on attributes about the request and/or target
-                resource. JSON Example.
+                resource.
 
-                .. code-block:: python
+                **JSON Example**
+
+                ::
 
                     {
                       "bindings": [
@@ -1376,6 +1378,7 @@ async def set_iam_policy(
                         description: Does not grant access after Sep 2020
                         expression: request.time < timestamp('2020-10-01T00:00:00.000Z')
 
+
                 For a description of IAM and its features, see the `IAM
                 developer's
                 guide <https://cloud.google.com/iam/docs>`__.
@@ -1448,9 +1451,11 @@ async def get_iam_policy(
                 optionally specify a ``condition``, which is a logic
                 expression that further constrains the role binding
                 based on attributes about the request and/or target
-                resource. JSON Example.
+                resource.
 
-                .. code-block:: python
+                **JSON Example**
+
+                ::
 
                     {
                       "bindings": [
@@ -1495,6 +1500,7 @@ async def get_iam_policy(
                         description: Does not grant access after Sep 2020
                         expression: request.time < timestamp('2020-10-01T00:00:00.000Z')
 
+
                 For a description of IAM and its features, see the `IAM
                 developer's
                 guide <https://cloud.google.com/iam/docs>`__.

diff --git a/...e-cloud-gke-hub/google/cloud/gkehub_v1beta1/services/gke_hub_membership_service/client.py b/...e-cloud-gke-hub/google/cloud/gkehub_v1beta1/services/gke_hub_membership_service/client.py
@@ -1569,9 +1569,11 @@ def set_iam_policy(
                 optionally specify a ``condition``, which is a logic
                 expression that further constrains the role binding
                 based on attributes about the request and/or target
-                resource. JSON Example.
+                resource.
 
-                .. code-block:: python
+                **JSON Example**
+
+                ::
 
                     {
                       "bindings": [
@@ -1616,6 +1618,7 @@ def set_iam_policy(
                         description: Does not grant access after Sep 2020
                         expression: request.time < timestamp('2020-10-01T00:00:00.000Z')
 
+
                 For a description of IAM and its features, see the `IAM
                 developer's
                 guide <https://cloud.google.com/iam/docs>`__.
@@ -1688,9 +1691,11 @@ def get_iam_policy(
                 optionally specify a ``condition``, which is a logic
                 expression that further constrains the role binding
                 based on attributes about the request and/or target
-                resource. JSON Example.
+                resource.
 
-                .. code-block:: python
+                **JSON Example**
+
+                ::
 
                     {
                       "bindings": [
@@ -1735,6 +1740,7 @@ def get_iam_policy(
                         description: Does not grant access after Sep 2020
                         expression: request.time < timestamp('2020-10-01T00:00:00.000Z')
 
+
                 For a description of IAM and its features, see the `IAM
                 developer's
                 guide <https://cloud.google.com/iam/docs>`__.

diff --git a/packages/google-cloud-gke-hub/noxfile.py b/packages/google-cloud-gke-hub/noxfile.py
@@ -265,7 +265,7 @@ def cover(session):
     test runs (not system test runs), and then erases coverage data.
     """
     session.install("coverage", "pytest-cov")
-    session.run("coverage", "report", "--show-missing", "--fail-under=99")
+    session.run("coverage", "report", "--show-missing", "--fail-under=100")
 
     session.run("coverage", "erase")
 

diff --git a/packages/google-cloud-gke-hub/owlbot.py b/packages/google-cloud-gke-hub/owlbot.py
@@ -80,33 +80,6 @@
             //container.googleapis.com/projects/my-"""
     )
 
-    # work around issues with docstrings
-    s.replace(
-        library / "google/cloud/**/*.py",
-        """resource.
-                \*\*JSON Example\*\*
-                ::""",
-        """resource. JSON Example.
-
-                .. code-block:: python\n""",
-    )
-
-    s.replace(
-        library / "google/cloud/**/*.py",
-        """\*\*YAML Example\*\*
-                ::""",
-        """\n                **YAML Example**
-
-                ::\n""",
-    )
-
-    s.replace(library / "google/cloud/**/*.py",
-        """                For a description of IAM and its features, see the `IAM
-                developer's""",
-        """\n                For a description of IAM and its features, see the `IAM
-                developer's"""
-    )
-
     excludes=[
         "setup.py",
         "README.rst",
@@ -166,7 +139,7 @@
 # Add templated files
 # ----------------------------------------------------------------------------
 
-templated_files = common.py_library(cov_level=99, microgenerator=True)
+templated_files = common.py_library(microgenerator=True)
 python.py_samples(skip_readmes=True)
 
 # the microgenerator has a good coveragerc file

diff --git a/...s/google-cloud-gke-hub/tests/unit/gapic/gkehub_v1beta1/test_gke_hub_membership_service.py b/...s/google-cloud-gke-hub/tests/unit/gapic/gkehub_v1beta1/test_gke_hub_membership_service.py
@@ -3371,7 +3371,7 @@ def test_delete_operation(transport: str = "grpc"):
 
 
 @pytest.mark.asyncio
-async def test_delete_operation(transport: str = "grpc"):
+async def test_delete_operation_async(transport: str = "grpc"):
     client = GkeHubMembershipServiceAsyncClient(
         credentials=ga_credentials.AnonymousCredentials(),
         transport=transport,
@@ -3510,7 +3510,7 @@ def test_cancel_operation(transport: str = "grpc"):
 
 
 @pytest.mark.asyncio
-async def test_cancel_operation(transport: str = "grpc"):
+async def test_cancel_operation_async(transport: str = "grpc"):
     client = GkeHubMembershipServiceAsyncClient(
         credentials=ga_credentials.AnonymousCredentials(),
         transport=transport,
@@ -3649,7 +3649,7 @@ def test_get_operation(transport: str = "grpc"):
 
 
 @pytest.mark.asyncio
-async def test_get_operation(transport: str = "grpc"):
+async def test_get_operation_async(transport: str = "grpc"):
     client = GkeHubMembershipServiceAsyncClient(
         credentials=ga_credentials.AnonymousCredentials(),
         transport=transport,
@@ -3794,7 +3794,7 @@ def test_list_operations(transport: str = "grpc"):
 
 
 @pytest.mark.asyncio
-async def test_list_operations(transport: str = "grpc"):
+async def test_list_operations_async(transport: str = "grpc"):
     client = GkeHubMembershipServiceAsyncClient(
         credentials=ga_credentials.AnonymousCredentials(),
         transport=transport,
@@ -3939,7 +3939,7 @@ def test_list_locations(transport: str = "grpc"):
 
 
 @pytest.mark.asyncio
-async def test_list_locations(transport: str = "grpc"):
+async def test_list_locations_async(transport: str = "grpc"):
     client = GkeHubMembershipServiceAsyncClient(
         credentials=ga_credentials.AnonymousCredentials(),
         transport=transport,