chore: Update dialogflow_cx_webhook snippet to match NodeJS (#409)

* chore: Update dialogflow_cx_webhook snippet to match NodeJS * Updates noxfile to skip deps install, if empty; otherwise an exception occurs
googleapis · Jun 28, 2022 · 5a59aa6 · 5a59aa6
1 parent b8bbe05
commit 5a59aa6
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 26 deletions.
diff --git a/packages/google-cloud-dialogflow-cx/noxfile.py b/packages/google-cloud-dialogflow-cx/noxfile.py
@@ -376,7 +376,8 @@ def prerelease_deps(session):
     deps = [dep for dep in deps if dep not in prerel_deps]
     # We use --no-deps to ensure that pre-release versions aren't overwritten
     # by the version ranges in setup.py.
-    session.install(*deps)
+    if deps:
+        session.install(*deps)
     session.install("--no-deps", "-e", ".[all]")
 
     # Print out prerelease package versions

diff --git a/packages/google-cloud-dialogflow-cx/samples/snippets/webhook.py b/packages/google-cloud-dialogflow-cx/samples/snippets/webhook.py
@@ -25,36 +25,29 @@ def handle_webhook(request):
     tag = req["fulfillmentInfo"]["tag"]
 
     if tag == "Default Welcome Intent":
-        # You can also use the google.cloud.dialogflowcx_v3.types.WebhookRequest protos instead of manually writing the json object
-        # Please see https://googleapis.dev/python/dialogflow/latest/dialogflow_v2/types.html?highlight=webhookresponse#google.cloud.dialogflow_v2.types.WebhookResponse for an overview
-        res = {
-            "fulfillment_response": {
-                "messages": [{"text": {"text": ["Hi from a GCF Webhook"]}}]
-            }
-        }
+        text = "Hello from a GCF Webhook"
     elif tag == "get-name":
-        res = {
-            "fulfillment_response": {
-                "messages": [{"text": {"text": ["My name is Phlowhook"]}}]
-            }
-        }
+        text = "My name is Flowhook"
     else:
-        res = {
-            "fulfillment_response": {
-                "messages": [
-                    {
-                        "text": {
-                            "text": [
-                                f"There are no fulfillment responses defined for {tag} tag"
-                            ]
-                        }
+        text = f"There are no fulfillment responses defined for {tag} tag"
+
+    # You can also use the google.cloud.dialogflowcx_v3.types.WebhookRequest protos instead of manually writing the json object
+    # Please see https://googleapis.dev/python/dialogflow/latest/dialogflow_v2/types.html?highlight=webhookresponse#google.cloud.dialogflow_v2.types.WebhookResponse for an overview
+    res = {
+        "fulfillment_response": {
+            "messages": [
+                {
+                    "text": {
+                        "text": [
+                            text
+                        ]
                     }
-                ]
-            }
+                }
+            ]
         }
+    }
 
     # Returns json
     return res
 
-
 # [END dialogflow_cx_webhook]
diff --git a/packages/google-cloud-dialogflow-cx/samples/snippets/webhook_test.py b/packages/google-cloud-dialogflow-cx/samples/snippets/webhook_test.py
@@ -31,4 +31,4 @@ def app():
 def test_handle_webhook(app):
     with app.test_request_context(json=request):
         res = handle_webhook(flask.request)
-        assert "Hi from a GCF Webhook" in str(res)
+        assert "Hello from a GCF Webhook" in str(res)