Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove src folder from source #6210

Merged
merged 6 commits into from
May 19, 2023

Conversation

vishwarajanand
Copy link
Contributor

@vishwarajanand vishwarajanand commented May 10, 2023

src folder doesn't seem to be used in the repo, so it should be removed.

BREAKING_CHANGE_REASON="BC check detects a missing /src folder hence complaining"

@bshaffer
Copy link
Contributor

bshaffer commented May 11, 2023

This is being referenced in our release script and composer.json, so we will need to make sure that those are updated:

@vishwarajanand
Copy link
Contributor Author

vishwarajanand commented May 12, 2023

Thanks for the tip, @bshaffer .
I also added a BC justification to ignore the missing /src logs in the BC checks. Old logs here

Also, I am not sure how to fix the release scripts. Hoping your PR #1949 addresses it.

@vishwarajanand vishwarajanand marked this pull request as ready for review May 12, 2023 12:40
@vishwarajanand vishwarajanand requested review from a team as code owners May 12, 2023 12:40
@bshaffer bshaffer merged commit 48b9c52 into googleapis:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants