Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system tests: remove duplicate tests #786

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions system-test/bigquery.js
Original file line number Diff line number Diff line change
Expand Up @@ -139,14 +139,6 @@ describe('BigQuery', function() {
});
});

it('should list datasets with autoPaginate', function(done) {
bigquery.getDatasets(function(err, datasets) {
assert(datasets.length > 0);
assert(datasets[0] instanceof Dataset);
done();
});
});

it('should list datasets as a stream', function(done) {
var datasetEmitted = false;

Expand Down Expand Up @@ -237,14 +229,6 @@ describe('BigQuery', function() {
});
});

it('should list jobs with autoPaginate', function(done) {
bigquery.getJobs(function(err, jobs) {
assert.ifError(err);
assert(jobs[0] instanceof Job);
done();
});
});

it('should list jobs as a stream', function(done) {
var jobEmitted = false;

Expand Down Expand Up @@ -319,14 +303,6 @@ describe('BigQuery', function() {
});
});

it('should get the rows in a table with autoPaginate', function(done) {
table.getRows(function(err, rows) {
assert.ifError(err);
assert(Array.isArray(rows));
done();
});
});

it('should get the rows in a table via stream', function(done) {
table.getRows()
.on('error', done)
Expand Down
13 changes: 1 addition & 12 deletions system-test/datastore.js
Original file line number Diff line number Diff line change
Expand Up @@ -327,18 +327,7 @@ describe('datastore', function() {
});
});

it('should run query with autoPaginate', function(done) {
var q = ds.createQuery('Character')
.hasAncestor(ancestor);

ds.runQuery(q, function(err, results) {
assert.ifError(err);
assert.equal(results.length, characters.length);
done();
});
});

it('should not go over a limit with autoPaginate', function(done) {
it('should not go over a limit', function(done) {
var limit = 3;

var q = ds.createQuery('Character')
Expand Down
8 changes: 0 additions & 8 deletions system-test/search.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,6 @@ describe('Search', function() {
});
});

it('should get all indexes with autoPaginate', function(done) {
search.getIndexes({ autoPaginate: true }, function(err, indexes) {
assert.ifError(err);
assert(indexes.length > 0);
done();
});
});

it('should get all indexes in stream mode', function(done) {
var resultsMatched = 0;

Expand Down
21 changes: 0 additions & 21 deletions system-test/storage.js
Original file line number Diff line number Diff line change
Expand Up @@ -409,18 +409,6 @@ describe('storage', function() {
});
});

it('should get buckets with autoPaginate', function(done) {
storage.getBuckets({
autoPaginate: true
}, function(err, buckets) {
assert.ifError(err);

assert(buckets.length > 0);
assert(buckets[0] instanceof Bucket);
done();
});
});

it('should get buckets as a stream', function(done) {
var bucketEmitted = false;

Expand Down Expand Up @@ -776,15 +764,6 @@ describe('storage', function() {
});
});

it('should get files with autoPaginate', function(done) {
bucket.getFiles({ autoPaginate: true }, function(err, files) {
assert.ifError(err);
assert.strictEqual(files.length, filenames.length);
assert(files[0] instanceof File);
done();
});
});

it('should get files as a stream', function(done) {
var fileEmitted = false;

Expand Down