-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: add 502 errors to retry logic #769
core: add 502 errors to retry logic #769
Conversation
Do we actually want to retry requests for bad gateways? If we do great, but I'd rather not add this code if it is only to work around Travis. |
I don't actually know. We currently support:
And 502:
|
@jgeewax any idea if we should we run our retry logic when the server responds with a 502? |
I think this is reasonable (to retry when we get a 502) as the request (as far as we're concerned) is perfectly fine, but the server behind the proxy had an issue... |
Sounds good. Thanks! |
core: add 502 errors to retry logic
- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 434859890 Source-Link: googleapis/googleapis@bc2432d Source-Link: googleapis/googleapis-gen@930b673 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwYjY3MzEwM2U5MjUyM2Y4Y2ZlZDM4ZGVjZDdkM2FmYWU4ZWJlNyJ9
Source-Link: googleapis/googleapis@9fac84a Source-Link: googleapis/googleapis-gen@12ae1da Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjEyYWUxZGE3YzEzNDcyYTExZTFhNGE2MTg5YWFiMTBmNzgzYzU4NTMifQ==
🤖 I have created a release \*beep\* \*boop\* --- ### [4.5.3](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.2...v4.5.3) (2021-06-29) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#772](https://www.github.com/googleapis/nodejs-speech/issues/772)) ([582e5b7](https://www.github.com/googleapis/nodejs-speech/commit/582e5b71c68be635f7ce775f06d5e7b02180fbef)) * make request optional in all cases ([#768](https://www.github.com/googleapis/nodejs-speech/issues/768)) ([83e1b7b](https://www.github.com/googleapis/nodejs-speech/commit/83e1b7bd4cc2d6ffd95769a4a6f519ab23b9bc71)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
* feat: Update Compute Engine API to revision 20221224 (#760) Source-Link: googleapis/googleapis@17d5613 Source-Link: googleapis/googleapis-gen@42cd552 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjQyY2Q1NTJmYTViZTk1YmU1Y2U1MTM2YmE5M2U4MzM4OGI3NTkxZDgifQ== * feat: Update Compute Engine API to revision 20221224 (#760) Source-Link: googleapis/googleapis@17d5613 Source-Link: googleapis/googleapis-gen@42cd552 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjQyY2Q1NTJmYTViZTk1YmU1Y2U1MTM2YmE5M2U4MzM4OGI3NTkxZDgifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Update Compute Engine API to revision 20230103 (#769) Source-Link: googleapis/googleapis@9fac84a Source-Link: googleapis/googleapis-gen@12ae1da Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjEyYWUxZGE3YzEzNDcyYTExZTFhNGE2MTg5YWFiMTBmNzgzYzU4NTMifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
🤖 I have created a release \*beep\* \*boop\* --- ### [4.5.3](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.2...v4.5.3) (2021-06-29) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#772](https://www.github.com/googleapis/nodejs-speech/issues/772)) ([582e5b7](https://www.github.com/googleapis/nodejs-speech/commit/582e5b71c68be635f7ce775f06d5e7b02180fbef)) * make request optional in all cases ([#768](https://www.github.com/googleapis/nodejs-speech/issues/768)) ([83e1b7b](https://www.github.com/googleapis/nodejs-speech/commit/83e1b7bd4cc2d6ffd95769a4a6f519ab23b9bc71)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Our system tests have been flaking out again. We previously implemented retry logic with exponential backoff to try to resolve the problem. I'm wondering if we need to loosen what triggers the retry logic.
Currently, we check if the status code returned is: 429, 500, or 503. This PR adds 502 to the list, "Bad Gateway", as an attempt to resolve this consistently failing test when run on Travis (but not locally):