fixes #38 return key/prop combined object. #75

stephenplusplus · 2014-07-31T19:56:51Z

This currently only patches .get & .getAll to return a single array of combined key/property objects. I will move on to query if this seems headed in the right direction 👍

regression/datastore.js

          if (err) return done(err);
-          assert.deepEqual(obj, post);
+          assert.deepEqual(entity.properties, post);


stephenplusplus · 2014-08-01T00:22:10Z

Made the same changes with runQuery as well as added tests that were previously missing!

lib/datastore/index.js

+    };
+  });
+}
+


rakyll · 2014-08-01T17:26:36Z

Could you fix the docs in this PR as well?

stephenplusplus · 2014-08-01T17:46:25Z

Could you fix the docs in this PR as well?

The readme and jsdoc for runQuery are updated. Did I miss anything?

lib/datastore/entity.js

+    };
+  });
+};
+


rakyll · 2014-08-01T18:15:44Z

The readme and jsdoc for runQuery are updated. Did I miss anything?

Sorry, I've missed them while browsing on a mobile device.

fixes #38 return key/prop combined object.

rakyll · 2014-08-01T18:22:49Z

Thanks :)

Broken by API change in googleapis#75.

Broken by api change in googleapis#75.

🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/nodejs-artifact-registry/compare/v1.0.7...v1.1.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#74](https://www.github.com/googleapis/nodejs-artifact-registry/issues/74)) ([a4c3f55](https://www.github.com/googleapis/nodejs-artifact-registry/commit/a4c3f556afe45914ce303ac665e56487f6ed8c5d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* feat: support regapic LRO Use gapic-generator-typescript v2.15.1. PiperOrigin-RevId: 456946341 Source-Link: googleapis/googleapis@88fd18d Source-Link: googleapis/googleapis-gen@accfa37 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWNjZmEzNzFmNjY3NDM5MzEzMzM1YzY0MDQyYjA2M2MxYzUzMTAyZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [2.1.0](googleapis/nodejs-storage-transfer@v2.0.0...v2.1.0) (2022-06-30) ### Features * **samples:** Add POSIX & Manifest samples ([#67](googleapis/nodejs-storage-transfer#67)) ([1056c9f](googleapis/nodejs-storage-transfer@1056c9f)) * support regapic LRO ([#75](googleapis/nodejs-storage-transfer#75)) ([cc80906](googleapis/nodejs-storage-transfer@cc80906)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [1.0.8](https://www.github.com/googleapis/nodejs-access-approval/compare/v1.0.7...v1.0.8) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#74](https://www.github.com/googleapis/nodejs-access-approval/issues/74)) ([e83da9b](https://www.github.com/googleapis/nodejs-access-approval/commit/e83da9b6ffa6ea7f268fd31db64a33ea288e651f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* docs(samples): add example tags to generated samples PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: googleapis/googleapis-gen@eb888bc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…andwritten libraries (#75) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 429395631 Source-Link: googleapis/googleapis@84594b3 Source-Link: googleapis/googleapis-gen@ed74f97 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9

🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.1](https://www.github.com/googleapis/nodejs-network-connectivity/compare/v1.2.0...v1.2.1) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#74](https://www.github.com/googleapis/nodejs-network-connectivity/issues/74)) ([e8c6f45](https://www.github.com/googleapis/nodejs-network-connectivity/commit/e8c6f45241e83e35dfddb22c708336b1d2e1c0a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* fix: bring common resources back * fix: webpack library name

rakyll reviewed Jul 31, 2014
View reviewed changes

regression/datastore.js

if (err) return done(err);

assert.deepEqual(obj, post);

assert.deepEqual(entity.properties, post);

This comment was marked as spam.

Sign in to view

fixes googleapis#38 datastore.get returns key/prop combined object.

7197b6c

stephenplusplus reviewed Aug 1, 2014
View reviewed changes

lib/datastore/index.js

};

});

}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

datastore.runQuery returns key/prop combined object.

2843275

stephenplusplus reviewed Aug 1, 2014
View reviewed changes

lib/datastore/entity.js

};

});

};

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

rakyll pushed a commit that referenced this pull request Aug 1, 2014

Merge pull request #75 from stephenplusplus/master

771d3cc

fixes #38 return key/prop combined object.

rakyll merged commit 771d3cc into googleapis:master Aug 1, 2014

silvolu added a commit to silvolu/gcloud-node that referenced this pull request Aug 1, 2014

fix(datastore): fix for filter by key regression test.

701bb88

Broken by API change in googleapis#75.

silvolu added a commit to silvolu/gcloud-node that referenced this pull request Aug 1, 2014

fix(datastore): fix regression test for filter by key.

bf895a9

Broken by api change in googleapis#75.

silvolu mentioned this pull request Aug 1, 2014

fix(datastore): fix regression test for filter by key. #89

Merged

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

Fix the linter (#75)

36f7838

sofisl pushed a commit that referenced this pull request Sep 27, 2022

chore(deps): lock file maintenance (#75)

d0e3bd8

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

Fix the linter (#75)

cede5d1

This was referenced Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

migrate code from googleapis/nodejs-os-login #3389

Closed

sofisl pushed a commit that referenced this pull request Oct 8, 2022

Fix the linter (#75)

8fb3ed9

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 11, 2022

chore(deps): lock file maintenance (#75)

392cf84

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-language #3395

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-storage-transfer #3590

Merged

migrate code from googleapis/nodejs-bigquery-storage #3599

Merged

sofisl added a commit that referenced this pull request Nov 11, 2022

feat: promote library to GA (#75)

4b1d1f6

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-access-approval #3605

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-api-gateway #3606

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-service-control #3609

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix(build): set default branch to main (#75)

0a20e2f

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-service-usage #3610

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

docs(nodejs): version support policy edits (#1346) (#75)

198a0a2

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-essential-contacts #3615

Merged

4 tasks

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-network-connectivity #3643

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl pushed a commit that referenced this pull request Nov 18, 2022

refactor: update proto namespaces (#75)

2243b1d

sofisl mentioned this pull request Nov 30, 2022

migrate code from googleapis/nodejs-datacatalog #3689

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 30, 2022

fix: bring common resources back (#75)

33c0d8d

* fix: bring common resources back * fix: webpack library name

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

chore: bump dlp to 0.7.0 (#75)

3bab2f9

sofisl pushed a commit that referenced this pull request Jan 24, 2023

chore: add Node.js 10 (#75)

eb3c699

sofisl pushed a commit that referenced this pull request Jan 25, 2023

chore: add Node.js 10 (#75)

c1f7ad1

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 13, 2023

chore: include build in eslintignore (#75)

919f93c

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

chore: move mocha options to mocha.opts (#75)

5f2b031

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes #38 return key/prop combined object. #75

fixes #38 return key/prop combined object. #75

stephenplusplus commented Jul 31, 2014

This comment was marked as spam.

stephenplusplus commented Aug 1, 2014

This comment was marked as spam.

This comment was marked as spam.

rakyll commented Aug 1, 2014

stephenplusplus commented Aug 1, 2014

This comment was marked as spam.

This comment was marked as spam.

rakyll commented Aug 1, 2014

rakyll commented Aug 1, 2014

fixes #38 return key/prop combined object. #75

fixes #38 return key/prop combined object. #75

Conversation

stephenplusplus commented Jul 31, 2014

This comment was marked as spam.

stephenplusplus commented Aug 1, 2014

This comment was marked as spam.

This comment was marked as spam.

rakyll commented Aug 1, 2014

stephenplusplus commented Aug 1, 2014

This comment was marked as spam.

This comment was marked as spam.

rakyll commented Aug 1, 2014

rakyll commented Aug 1, 2014