-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #38 return key/prop combined object. #75
Conversation
if (err) return done(err); | ||
assert.deepEqual(obj, post); | ||
assert.deepEqual(entity.properties, post); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Made the same changes with |
}; | ||
}); | ||
} | ||
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Could you fix the docs in this PR as well? |
The readme and jsdoc for |
}; | ||
}); | ||
}; | ||
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sorry, I've missed them while browsing on a mobile device. |
fixes #38 return key/prop combined object.
Thanks :) |
Broken by API change in googleapis#75.
Broken by api change in googleapis#75.
🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/nodejs-artifact-registry/compare/v1.0.7...v1.1.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#74](https://www.github.com/googleapis/nodejs-artifact-registry/issues/74)) ([a4c3f55](https://www.github.com/googleapis/nodejs-artifact-registry/commit/a4c3f556afe45914ce303ac665e56487f6ed8c5d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/nodejs-artifact-registry/compare/v1.0.7...v1.1.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#74](https://www.github.com/googleapis/nodejs-artifact-registry/issues/74)) ([a4c3f55](https://www.github.com/googleapis/nodejs-artifact-registry/commit/a4c3f556afe45914ce303ac665e56487f6ed8c5d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
* feat: support regapic LRO Use gapic-generator-typescript v2.15.1. PiperOrigin-RevId: 456946341 Source-Link: googleapis/googleapis@88fd18d Source-Link: googleapis/googleapis-gen@accfa37 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWNjZmEzNzFmNjY3NDM5MzEzMzM1YzY0MDQyYjA2M2MxYzUzMTAyZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [2.1.0](googleapis/nodejs-storage-transfer@v2.0.0...v2.1.0) (2022-06-30) ### Features * **samples:** Add POSIX & Manifest samples ([#67](googleapis/nodejs-storage-transfer#67)) ([1056c9f](googleapis/nodejs-storage-transfer@1056c9f)) * support regapic LRO ([#75](googleapis/nodejs-storage-transfer#75)) ([cc80906](googleapis/nodejs-storage-transfer@cc80906)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [1.0.8](https://www.github.com/googleapis/nodejs-access-approval/compare/v1.0.7...v1.0.8) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#74](https://www.github.com/googleapis/nodejs-access-approval/issues/74)) ([e83da9b](https://www.github.com/googleapis/nodejs-access-approval/commit/e83da9b6ffa6ea7f268fd31db64a33ea288e651f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
* docs(samples): add example tags to generated samples PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: googleapis/googleapis-gen@eb888bc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…andwritten libraries (#75) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 429395631 Source-Link: googleapis/googleapis@84594b3 Source-Link: googleapis/googleapis-gen@ed74f97 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9
🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.1](https://www.github.com/googleapis/nodejs-network-connectivity/compare/v1.2.0...v1.2.1) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#74](https://www.github.com/googleapis/nodejs-network-connectivity/issues/74)) ([e8c6f45](https://www.github.com/googleapis/nodejs-network-connectivity/commit/e8c6f45241e83e35dfddb22c708336b1d2e1c0a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
* fix: bring common resources back * fix: webpack library name
This currently only patches
.get
&.getAll
to return a single array of combined key/property objects. I will move on toquery
if this seems headed in the right direction 👍