remove topic.options.autoCreate, add topic.getMetadata #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
stephenplusplus
changed the title
|
Assigned for a review :) |
| @@ -199,16 +199,10 @@ PubSub.prototype.getTopics = function(query, callback) { | |||
| * | |||
| * @example | |||
| * pubsub.createTopic('my-new-topic', function(err, topic, apiResponse) { | |||
| * topic.publish({ | |||
| * data: 'New message!' | |||
| * }, function(err) {}); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
callmehiphop
added a commit
that referenced
this pull request
Jul 27, 2015
…reate remove topic.options.autoCreate, add topic.getMetadata
|
Looks great, thanks! |
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
sed -i -e 's/\[\(.*\)\](\(.*\))/{@link \2| \1}/' src/**/*.ts
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 471923438 Source-Link: googleapis/googleapis@62995d0 Source-Link: googleapis/googleapis-gen@96ba173 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTZiYTE3MzFjNzEyYTY5Mzk5NWRlNzUzNzg5NDg3ODFhZjI4MzczOSJ9 fix: allow passing gax instance to client constructor PiperOrigin-RevId: 470911839 Source-Link: googleapis/googleapis@3527566 Source-Link: googleapis/googleapis-gen@f16a1d2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9 feat: accept google-gax instance as a parameter Please see the documentation of the client constructor for details. PiperOrigin-RevId: 470332808 Source-Link: googleapis/googleapis@d4a2367 Source-Link: googleapis/googleapis-gen@e97a1ac Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](googleapis/nodejs-dlp@v4.1.1...v4.2.0) (2022-09-22) ### Features * Add Deidentify action ([#742](googleapis/nodejs-dlp#742)) ([27bb912](googleapis/nodejs-dlp@27bb912)) ### Bug Fixes * Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-dlp/issues/1553)) ([#741](googleapis/nodejs-dlp#741)) ([655d6af](googleapis/nodejs-dlp@655d6af)) * Preserve default values in x-goog-request-params header ([#746](googleapis/nodejs-dlp#746)) ([7c53b9f](googleapis/nodejs-dlp@7c53b9f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #696
Related googleapis/google-cloud-python#949
This:
topic.options.autoCreatetopic.getMetadata()autoCreate