Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [cloudbuild] Add PrivateServiceConnect option to WorkerPool #5770

Merged
merged 4 commits into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ option (google.api.resource_definition) = {
type: "pubsub.googleapis.com/Topic"
pattern: "projects/{project}/topics/{topic}"
};
option (google.api.resource_definition) = {
type: "compute.googleapis.com/NetworkAttachment"
pattern: "projects/{project}/regions/{region}/networkAttachments/{networkattachment}"
};
option (google.api.resource_definition) = {
type: "cloudbuild.googleapis.com/Repository"
pattern: "projects/{project}/locations/{location}/connections/{connection}/repositories/{repository}"
Expand Down Expand Up @@ -2583,11 +2587,54 @@ message PrivatePoolV1Config {
[(google.api.field_behavior) = IMMUTABLE];
}

// Defines the Private Service Connect network configuration for the pool.
message PrivateServiceConnect {
// Required. Immutable. The network attachment that the worker network
// interface is peered to. Must be in the format
// `projects/{project}/regions/{region}/networkAttachments/{networkAttachment}`.
// The region of network attachment must be the same as the worker pool.
// See [Network
// Attachments](https://cloud.google.com/vpc/docs/about-network-attachments)
string network_attachment = 1 [
(google.api.field_behavior) = IMMUTABLE,
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = {
type: "compute.googleapis.com/NetworkAttachment"
}
];

// Required. Immutable. Disable public IP on the primary network interface.
//
// If true, workers are created without any public address, which prevents
// network egress to public IPs unless a network proxy is configured.
// If false, workers are created with a public address which allows for
// public internet egress. The public address only applies to traffic
// through the primary network interface.
// If `route_all_traffic` is set to true, all traffic will go through the
// non-primary network interface, this boolean has no effect.
bool public_ip_address_disabled = 2 [
(google.api.field_behavior) = REQUIRED,
(google.api.field_behavior) = IMMUTABLE
];

// Immutable. Route all traffic through PSC interface. Enable this if you
// want full control of traffic in the private pool. Configure Cloud NAT for
// the subnet of network attachment if you need to access public Internet.
//
// If false, Only route private IPs, e.g. 10.0.0.0/8, 172.16.0.0/12, and
// 192.168.0.0/16 through PSC interface.
bool route_all_traffic = 3 [(google.api.field_behavior) = IMMUTABLE];
}

// Machine configuration for the workers in the pool.
WorkerConfig worker_config = 1;

// Network configuration for the pool.
NetworkConfig network_config = 2;

// Immutable. Private Service Connect(PSC) Network configuration for the pool.
PrivateServiceConnect private_service_connect = 5
[(google.api.field_behavior) = IMMUTABLE];
}

// Request to create a new `WorkerPool`.
Expand Down
115 changes: 115 additions & 0 deletions packages/google-devtools-cloudbuild/protos/protos.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading