feat: [compute] Trusted Private Cloud support, use the universeDomain parameter #5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
Source-Link: googleapis/googleapis@ccaed1e Source-Link: googleapis/googleapis-gen@5cc3f75 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjVjYzNmNzU3MjZiNjZjM2MxMDIxNmJkZjBmYjQ5YTUxMGI5MTkxMzYifQ==
|
/gcbrun |
gcf-owl-bot
bot
requested review from
yoshi-approver and
a team
as code owners
|
/gcbrun |
PiperOrigin-RevId: 604765466 Source-Link: googleapis/googleapis@40203ca Source-Link: googleapis/googleapis-gen@07b7f3d Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjA3YjdmM2RhZDhhYTE5MTJkNGFjZGNmZDYzNjViYjQyMzZlNGI1NGIifQ==
gcf-owl-bot
bot
changed the title
|
/gcbrun |
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
|
/gcbrun |
sofisl
approved these changes
Feb 7, 2024
sofisl
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 604765466
Source-Link: googleapis/googleapis@40203ca
Source-Link: https://github.com/googleapis/googleapis-gen/commit/07b7f3dad8aa1912d4acdcfd6365bb4236e4b54b
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjA3YjdmM2RhZDhhYTE5MTJkNGFjZGNmZDYzNjViYjQyMzZlNGI1NGIifQ==
BEGIN_NESTED_COMMIT
build: [compute] add dependencies to nodejs_gapic_assembly_pkg target (#880)
Source-Link: googleapis/googleapis@ccaed1e
Source-Link: https://github.com/googleapis/googleapis-gen/commit/5cc3f75726b66c3c10216bdf0fb49a510b919136
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjVjYzNmNzU3MjZiNjZjM2MxMDIxNmJkZjBmYjQ5YTUxMGI5MTkxMzYifQ==
END_NESTED_COMMIT