storage: add download() method #381

stephenplusplus · 2015-02-04T19:48:33Z

Fixes #367

Adds a download method to a File object:

// Getting the contents of a file.
file.download(function(err, contents) {})
file.download({ start: 0, end: 100 }, function(err, contents) {});

// Writing the file to a local destination
file.download({ destination: '/Users/stephen/file.txt' }, function(err) {});
file.download({ start: 0, end: 100, destination: '/Users/stephen/file.txt' }, function(err) {});

This method just blankets file.createReadStream(options), so the options passed to download are passed up to createReadStream.

lib/storage/file.js

+    fileStream
+      .on('error', callback)
+      .pipe(fs.createWriteStream(destination))
+      .on('error', callback)


ryanseys · 2015-02-09T15:37:45Z

Will require a rebase

stephenplusplus · 2015-02-09T19:35:38Z

Using the new once module + rebased.

storage: add download() method

ryanseys · 2015-02-09T20:05:39Z

LGTM! :) 🚢

…ed existing docs. (#381) Clients receive detailed OutputResult in ExportAssetsResponse. PiperOrigin-RevId: 326582222 Source-Author: Google APIs <noreply@google.com> Source-Date: Thu Aug 13 20:45:57 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 3a54e988edcbdef1e47c6ac19d3074a87214f667 Source-Link: googleapis/googleapis@3a54e98

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [null-loader](https://togithub.com/webpack-contrib/null-loader) | devDependencies | major | [`^3.0.0` -> `^4.0.0`](https://renovatebot.com/diffs/npm/null-loader/3.0.0/4.0.0) | --- ### Release Notes <details> <summary>webpack-contrib/null-loader</summary> ### [`v4.0.0`](https://togithub.com/webpack-contrib/null-loader/blob/master/CHANGELOG.md#400-httpsgithubcomwebpack-contribnull-loadercomparev300v400-2020-04-15) [Compare Source](https://togithub.com/webpack-contrib/null-loader/compare/v3.0.0...v4.0.0) ##### Bug Fixes - support `webpack@5` ##### ⚠ BREAKING CHANGES - minimum required Nodejs version is `10.13` </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-redis).

🤖 I have created a release \*beep\* \*boop\* --- ## [3.8.0](https://www.github.com/googleapis/nodejs-language/compare/v3.7.2...v3.8.0) (2020-02-28) ### Features * export protos in src/index.ts ([482fb10](https://www.github.com/googleapis/nodejs-language/commit/482fb10bc1d4f01bd3de38a0301cda2a2efb491d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/mocha](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/8.2.3/9.1.1) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/compatibility-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/confidence-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-phishing-protection).

🤖 I have created a release \*beep\* \*boop\* --- ## [3.8.0](https://www.github.com/googleapis/nodejs-language/compare/v3.7.2...v3.8.0) (2020-02-28) ### Features * export protos in src/index.ts ([482fb10](https://www.github.com/googleapis/nodejs-language/commit/482fb10bc1d4f01bd3de38a0301cda2a2efb491d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

…381) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/a8ab5675-1982-4cf5-b9b7-36794038b975/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@8cf6d28

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/4de22315-84b1-493d-8da2-dfa7688128f5/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@94421c4

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jsdoc](https://togithub.com/jsdoc/jsdoc) | [`^3.6.2` -> `^4.0.0`](https://renovatebot.com/diffs/npm/jsdoc/3.6.11/4.0.0) | [![age](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/compatibility-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/confidence-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>jsdoc/jsdoc</summary> ### [`v4.0.0`](https://togithub.com/jsdoc/jsdoc/blob/HEAD/CHANGES.md#400-November-2022) [Compare Source](https://togithub.com/jsdoc/jsdoc/compare/3.6.11...084218523a7d69fec14a852ce680f374f526af28) - JSDoc releases now use [semantic versioning](https://semver.org/). If JSDoc makes backwards-incompatible changes in the future, the major version will be incremented. - JSDoc no longer uses the [`taffydb`](https://taffydb.com/) package. If your JSDoc template or plugin uses the `taffydb` package, see the [instructions for replacing `taffydb` with `@jsdoc/salty`](https://togithub.com/jsdoc/jsdoc/tree/main/packages/jsdoc-salty#use-salty-in-a-jsdoc-template). - JSDoc now supports Node.js 12.0.0 and later. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-datalabeling).

🤖 I have created a release *beep* *boop* --- ## [4.0.1](googleapis/nodejs-secret-manager@v4.0.0...v4.0.1) (2022-06-30) ### Bug Fixes * **docs:** describe fallback rest option ([#379](googleapis/nodejs-secret-manager#379)) ([368cff5](googleapis/nodejs-secret-manager@368cff5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…ed existing docs. (#381) Clients receive detailed OutputResult in ExportAssetsResponse. PiperOrigin-RevId: 326582222 Source-Author: Google APIs <noreply@google.com> Source-Date: Thu Aug 13 20:45:57 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 3a54e988edcbdef1e47c6ac19d3074a87214f667 Source-Link: googleapis/googleapis@3a54e98

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: googleapis/googleapis-gen@eb888bc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9

This reverts commit 086cb96c21d21821619143f7ebbc33b5ade49a74.

* chore: release 5.3.0 * 🦉 Updates from OwlBot * 🦉 Updates from OwlBot * 🦉 Updates from OwlBot Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 470911839 Source-Link: googleapis/googleapis@3527566 Source-Link: googleapis/googleapis-gen@f16a1d2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9 feat: accept google-gax instance as a parameter Please see the documentation of the client constructor for details. PiperOrigin-RevId: 470332808 Source-Link: googleapis/googleapis@d4a2367 Source-Link: googleapis/googleapis-gen@e97a1ac Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2015

stephenplusplus force-pushed the spp--storage-download branch from 799d4bf to baae93f Compare February 4, 2015 19:49

stephenplusplus mentioned this pull request Feb 4, 2015

add download() method #367

Closed

ryanseys reviewed Feb 5, 2015
View reviewed changes

ryanseys mentioned this pull request Feb 5, 2015

Release 0.13.0? #382

Closed

stephenplusplus force-pushed the spp--storage-download branch from baae93f to 51d71c1 Compare February 5, 2015 20:17

storage: add download() method

132150c

stephenplusplus force-pushed the spp--storage-download branch from 47b69b3 to 132150c Compare February 9, 2015 19:34

ryanseys added a commit that referenced this pull request Feb 9, 2015

Merge pull request #381 from stephenplusplus/spp--storage-download

b52b28b

storage: add download() method

ryanseys merged commit b52b28b into googleapis:master Feb 9, 2015

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-language #3395

Merged

4 tasks

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-phishing-protection #3406

Merged

4 tasks

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-translate #3520

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 10, 2022

fix(docs): snippets are now replaced in jsdoc comments (#381)

4d8b647

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-cloud-container #3543

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-iot #3544

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-monitoring #3545

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

build(tests): fix coveralls and enable build cop (#381)

f68c28f

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-datalabeling #3548

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-secret-manager #3553

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-asset #3567

Merged

migrate code from googleapis/nodejs-talent #3568

Merged

sofisl pushed a commit that referenced this pull request Nov 16, 2022

Revert "chore(main): release 1.0.0 (#375)" (#381)

62ecc49

This reverts commit 086cb96c21d21821619143f7ebbc33b5ade49a74.

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 17, 2022

build: use c8 for coverage (#381)

6a85d85

This was referenced Nov 17, 2022

migrate code from googleapis/nodejs-compute #3666

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl mentioned this pull request Nov 30, 2022

migrate code from googleapis/nodejs-datacatalog #3689

Merged

4 tasks

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 13, 2023

chore: remove tslint.json (#381)

e2a66ed

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

chore: remove tslint.json (#381)

b88dc1a

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

storage: add download() method #381

storage: add download() method #381

stephenplusplus commented Feb 4, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ryanseys commented Feb 9, 2015

stephenplusplus commented Feb 9, 2015

ryanseys commented Feb 9, 2015

storage: add download() method #381

storage: add download() method #381

Conversation

stephenplusplus commented Feb 4, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ryanseys commented Feb 9, 2015

stephenplusplus commented Feb 9, 2015

ryanseys commented Feb 9, 2015