all: manage all outgoing requests in one place #278

stephenplusplus · 2014-11-04T21:50:13Z

I know, I know. Huge PR. I'm sorry :(

This depends on #276.

This gets rid of the connection module, and uses the abstracted google-service-account. I know we talked about bringing back support for pem files, so when that time comes, I can just add it in the gsa lib.

lib/pubsub/index.js

    credentials: options.credentials,
-    keyFilename: options.keyFilename,
+    keyFile: options.keyFilename,
    scopes: SCOPES
  });


lib/common/util.js

+var MAX_TOKEN_REFRESH_ATTEMPTS = 1;
+
+/** @const {object} gcloud-node's package.json file. */
+var PKG = require('../../package.json');


stephenplusplus · 2014-11-06T19:30:38Z

@ryanseys - cleaned up the makeAuthorizedRequest stuff -- it was badly broken. I hang my head :( stephenplusplus@cad6302

test/common/util.js

+
+      it('should try to reconnect if token invalid', function(done) {
+        var attempts = 0;
+        var expectedAttempts = 2;


ryanseys · 2014-11-06T21:04:05Z

Un-mergable but looks good enough for merge!

stephenplusplus · 2014-11-06T21:10:06Z

Haha cool. I keep breaking my own prs!

On Thursday, November 6, 2014, Ryan Seys notifications@github.com wrote:

Un-mergable but looks good enough for merge!

—
Reply to this email directly or view it on GitHub
#278 (comment)
.

stephenplusplus · 2014-11-06T21:28:21Z

Fixed the conflict. It's good to go, but I'll let it sit for a few in case @silvolu wants to take a looksee.

ryanseys · 2014-11-06T21:29:11Z

Silvano, merge when happy :)

all: manage all outgoing requests in one place

Co-authored-by: Benjamin E. Coe <bencoe@google.com>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/fc1dd810-ea11-44c0-ab02-fa000827a405/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@363fe30

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^10.0.0` -> `^11.0.0`](https://renovatebot.com/diffs/npm/sinon/10.0.0/11.1.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/11.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/11.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/11.1.0/compatibility-slim/10.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/11.1.0/confidence-slim/10.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v11.1.0`](https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#1110--2021-05-25) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v11.0.0...31be9a5d5a4762ef01cb195f29024616dfee9ce8) \================== - Add sinon.promise() implementation ([#2369](https://togithub.com/sinonjs/sinon/issues/2369)) - Set wrappedMethod on getters/setters ([#2378](https://togithub.com/sinonjs/sinon/issues/2378)) - \[Docs] Update fake-server usage & descriptions ([#2365](https://togithub.com/sinonjs/sinon/issues/2365)) - Fake docs improvement ([#2360](https://togithub.com/sinonjs/sinon/issues/2360)) - Update nise to 5.1.0 (fixed [#2318](https://togithub.com/sinonjs/sinon/issues/2318)) ### [`v11.0.0`](https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#1100--2021-05-24) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v10.0.1...v11.0.0) \================== - Explicitly use samsam 6.0.2 with fix for [#2345](https://togithub.com/sinonjs/sinon/issues/2345) - Update most packages ([#2371](https://togithub.com/sinonjs/sinon/issues/2371)) - Update compatibility docs ([#2366](https://togithub.com/sinonjs/sinon/issues/2366)) - Update packages (includes breaking fake-timers change, see [#2352](https://togithub.com/sinonjs/sinon/issues/2352)) - Warn of potential memory leaks ([#2357](https://togithub.com/sinonjs/sinon/issues/2357)) - Fix clock test errors ### [`v10.0.1`](https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#1001--2021-04-08) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v10.0.0...v10.0.1) \================== - Upgrade sinon components (bumps y18n to 4.0.1) - Bump y18n from 4.0.0 to 4.0.1 </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-recaptcha-enterprise).

@summer-ji-eng

…beta1` `batch_prediction_job.proto` (#278) * chore: update v2.14.2 gapic-generator-typescript Committer: @summer-ji-eng PiperOrigin-RevId: 434859890 Source-Link: googleapis/googleapis@bc2432d Source-Link: googleapis/googleapis-gen@930b673 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwYjY3MzEwM2U5MjUyM2Y4Y2ZlZDM4ZGVjZDdkM2FmYWU4ZWJlNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: add `service_account` to `BatchPredictionJob` in aiplatform `v1beta1` `batch_prediction_job.proto` PiperOrigin-RevId: 434935416 Source-Link: googleapis/googleapis@dfdd5ee Source-Link: googleapis/googleapis-gen@2774684 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjc3NDY4NGMzYjhiMjI2Mzk5MDk2ODhkMjk3ZDRmYTU5MWZkZTllYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [1.18.0](googleapis/nodejs-ai-platform@v1.17.0...v1.18.0) (2022-03-17) ### Features * add `service_account` to `BatchPredictionJob` in aiplatform `v1beta1` `batch_prediction_job.proto` ([#278](googleapis/nodejs-ai-platform#278)) ([1f05428](googleapis/nodejs-ai-platform@1f05428)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

stephenplusplus reviewed Nov 4, 2014
View reviewed changes

lib/pubsub/index.js

credentials: options.credentials,

keyFilename: options.keyFilename,

keyFile: options.keyFilename,

scopes: SCOPES

});

This comment was marked as spam.

Sign in to view

stephenplusplus force-pushed the spp--use-gsa branch from f8436f5 to 5c51510 Compare November 6, 2014 14:45

ryanseys reviewed Nov 6, 2014
View reviewed changes

stephenplusplus force-pushed the spp--use-gsa branch from 5c51510 to 97e4762 Compare November 6, 2014 18:51

ryanseys reviewed Nov 6, 2014
View reviewed changes

test/common/util.js

it('should try to reconnect if token invalid', function(done) {

var attempts = 0;

var expectedAttempts = 2;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

use google-service-account

81aba40

stephenplusplus force-pushed the spp--use-gsa branch from cad6302 to 81aba40 Compare November 6, 2014 21:27

silvolu added a commit that referenced this pull request Nov 6, 2014

Merge pull request #278 from stephenplusplus/spp--use-gsa

5483274

all: manage all outgoing requests in one place

silvolu merged commit 5483274 into googleapis:master Nov 6, 2014

chingor13 pushed a commit that referenced this pull request Aug 22, 2022

chore: match jsdoc with macro license (#278)

938a50e

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-language #3395

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 11, 2022

docs: use the jsdoc-fresh theme (#278)

7e4eb80

sofisl pushed a commit that referenced this pull request Oct 13, 2022

docs: use the jsdoc-fresh theme (#278)

f4d02ab

sofisl pushed a commit that referenced this pull request Nov 11, 2022

build: use c8 for coverage (#278)

775a19e

Co-authored-by: Benjamin E. Coe <bencoe@google.com>

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-dataproc #3533

Merged

migrate code from googleapis/nodejs-cloud-container #3543

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: release 1.6.1 (#278)

b60da0c

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-iot #3544

Merged

migrate code from googleapis/nodejs-monitoring #3545

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-talent #3568

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-bigquery-storage #3599

Merged

4 tasks

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl pushed a commit that referenced this pull request Nov 18, 2022

chore: update root proto namespace (#278)

7f20a80

sofisl mentioned this pull request Jan 26, 2023

migrate code from googleapis/nodejs-ai-platform #3892

Merged

4 tasks

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 13, 2023

chore: release 1.9.1 (#278)

4d89397

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

build: switch to GitHub magic proxy (#278)

dd88adf

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all: manage all outgoing requests in one place #278

all: manage all outgoing requests in one place #278

stephenplusplus commented Nov 4, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Nov 6, 2014

This comment was marked as spam.

This comment was marked as spam.

ryanseys commented Nov 6, 2014

stephenplusplus commented Nov 6, 2014

stephenplusplus commented Nov 6, 2014

ryanseys commented Nov 6, 2014

all: manage all outgoing requests in one place #278

all: manage all outgoing requests in one place #278

Conversation

stephenplusplus commented Nov 4, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Nov 6, 2014

This comment was marked as spam.

This comment was marked as spam.

ryanseys commented Nov 6, 2014

stephenplusplus commented Nov 6, 2014

stephenplusplus commented Nov 6, 2014

ryanseys commented Nov 6, 2014