Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add video intelligence v1beta2. #2613

Merged
merged 9 commits into from
Sep 18, 2017
Merged

Add video intelligence v1beta2. #2613

merged 9 commits into from
Sep 18, 2017

Conversation

lukesneeringer
Copy link
Contributor

@lukesneeringer lukesneeringer commented Sep 15, 2017 •
edited
Loading

This is an update to the video intelligence API, adding v1beta2, with new features. (I do not really know off hand what they are.)

@landrito Please sanity check.
@stephenplusplus Once Ernest has sanity checked, please merge and release to npm, and email me when this is done.

@lukesneeringer lukesneeringer self-assigned this Sep 15, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 458e35a on lukesneeringer:video into 8ca2a85 on GoogleCloudPlatform:master.

@lukesneeringer lukesneeringer mentioned this pull request Sep 15, 2017
Merged
callmehiphop
callmehiphop reviewed Sep 15, 2017
View reviewed changes
packages/video-intelligence/src/index.js Outdated

/*!
* @module video-intelligence
* @name VideoIntelligence

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7b0fbf8 on lukesneeringer:video into 8ca2a85 on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling faa4a18 on lukesneeringer:video into 8ca2a85 on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling faa4a18 on lukesneeringer:video into 8ca2a85 on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 83a119f on lukesneeringer:video into 8ca2a85 on GoogleCloudPlatform:master.

landrito
landrito approved these changes Sep 18, 2017
View reviewed changes
Copy link
Contributor

@landrito landrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity Check LGTM

@lukesneeringer
Copy link
Contributor Author

@stephenplusplus Can you release this to npm?

@lukesneeringer lukesneeringer requested a review from a team as a code owner September 18, 2017 21:04
@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 18, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f30071e on lukesneeringer:video into 7ab09a3 on GoogleCloudPlatform:master.

@googleapis googleapis deleted a comment from googlebot Sep 18, 2017
@googleapis googleapis deleted a comment from googlebot Sep 18, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d71bf14 on lukesneeringer:video into 7ab09a3 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 45137da into googleapis:master Sep 18, 2017
sofisl pushed a commit that referenced this pull request Sep 27, 2022
@lukesneeringer @stephenplusplus
Add video intelligence v1beta2. (#2613)
3e9475b
@sofisl sofisl mentioned this pull request Sep 27, 2022
Closed
4 tasks
This was referenced Nov 9, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callmehiphop callmehiphop callmehiphop left review comments

@landrito landrito landrito approved these changes

Assignees

@lukesneeringer lukesneeringer

Labels
api: video-intelligence cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lukesneeringer @coveralls @callmehiphop @landrito @stephenplusplus @googlebot