datastore: tests: refactor pb/transaction. #255

stephenplusplus · 2014-10-10T15:12:48Z

This makes it so protobuf request encoding/response decoding and transactional/non-transactional properties are all handled in one place.

lib/datastore/request.js

+
+  var pbKey = method[0].toUpperCase() + method.substr(1);
+  var pbRequest = new pb[pbKey + 'Request'](req).toBuffer();
+  var pbResponse = pb[pbKey + 'Response'];


ryanseys · 2014-10-12T22:33:17Z

Overall looks really good. Just wondering why createRequest_ takes a req object? It's confusing that a method that creates requests needs a "request". :) Can we clarify that?

stephenplusplus · 2014-10-12T22:34:12Z

You named it, bro :p. I was thinking that, too. How about makeReq like the
other places?

On Sunday, October 12, 2014, Ryan Seys notifications@github.com wrote:

Overall looks really good. Just wondering why createRequest_ takes a req
object? It's confusing that a method that creates requests needs a
"request". :) Can we clarify that?

—
Reply to this email directly or view it on GitHub
#255 (comment)
.

ryanseys · 2014-10-12T22:35:39Z

I renamed it from makeReq_. Yes we can change it back if you'd like, but that still doesn't help explain why it takes a request object :P

stephenplusplus · 2014-10-12T22:37:24Z

It's piping the request up to our "requester", adding headers along the
way. So, I guess the thought was make a request with this request object.
That was Burcu's design, just my interpretation ^

On Sunday, October 12, 2014, Ryan Seys notifications@github.com wrote:

I renamed it from makeReq_. Yes we can change it back if you'd like,
but that still doesn't help explain why it takes a request object :P

—
Reply to this email directly or view it on GitHub
#255 (comment)
.

stephenplusplus · 2014-10-12T22:38:24Z

And our requester is called request, which takes the request from our
makeReq request.

Whoa.

On Sunday, October 12, 2014, Stephen Sawchuk sawchuk@gmail.com wrote:

It's piping the request up to our "requester", adding headers along the
way. So, I guess the thought was make a request with this request object.
That was Burcu's design, just my interpretation ^

On Sunday, October 12, 2014, Ryan Seys <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

I renamed it from makeReq_. Yes we can change it back if you'd like,
but that still doesn't help explain why it takes a request object :P

—
Reply to this email directly or view it on GitHub
#255 (comment)
.

ryanseys · 2014-10-12T22:39:24Z

And if I recall correctly, we use the request library to send the requests ;)

stephenplusplus · 2014-10-13T13:34:08Z

-createRequest_
+makeReq_

silvolu · 2014-10-13T18:35:12Z

Maybe rename req to something like requestBody ?

stephenplusplus · 2014-10-13T18:47:20Z

Renamed to body

silvolu · 2014-10-13T19:29:48Z

@ryanseys any better?

ryanseys · 2014-10-13T20:02:02Z

Yes, this is better!

ryanseys · 2014-10-13T20:08:59Z

LGTM.

datastore: tests: refactor pb/transaction.

…#255)

gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:f93bb861d6f12574437bb9aee426b71eafd63b419669ff0ed029f4b7e7162e3f

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^12.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/12.20.13/14.17.0) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/compatibility-slim/12.20.13)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/confidence-slim/12.20.13)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-secret-manager).

…fo field (#255) PiperOrigin-RevId: 385847244 Source-Link: googleapis/googleapis@f84d1e2 Source-Link: googleapis/googleapis-gen@ff9cf56

* chore: migrate to owl bot * chore: copy files from googleapis-gen eebcfa346c9963da765cd71722c40e04dc3621dd * chore: run the post processor * 🦉 Updates from OwlBot * chore: update post processor docker image * 🦉 Updates from OwlBot Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

stephenplusplus added the in progress label Oct 10, 2014

stephenplusplus reviewed Oct 10, 2014
View reviewed changes

lib/datastore/request.js

var pbKey = method[0].toUpperCase() + method.substr(1);

var pbRequest = new pb[pbKey + 'Request'](req).toBuffer();

var pbResponse = pb[pbKey + 'Response'];

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus added ready for review and removed in progress labels Oct 10, 2014

datastore: tests: refactor pb/transaction.

00db490

stephenplusplus force-pushed the spp--pb-refactor branch from 263ff82 to 00db490 Compare October 12, 2014 15:30

rename createRequest_ to makeReq_

6648a34

datastore: parameter: req -> body

1436ef8

silvolu added a commit that referenced this pull request Oct 13, 2014

Merge pull request #255 from stephenplusplus/spp--pb-refactor

00e6466

datastore: tests: refactor pb/transaction.

silvolu merged commit 00e6466 into googleapis:master Oct 13, 2014

beriberikix removed the ready for review label Oct 13, 2014

chingor13 pushed a commit that referenced this pull request Aug 22, 2022

chore(deps): update dependency @types/mocha to v7 (#255)

73d2bd7

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

docs: update jsdoc license/samples-README (#255)

770f8ca

sofisl pushed a commit that referenced this pull request Sep 27, 2022

docs: add v1p2beta1 samples to README (#255)

a8b94d9

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Nov 9, 2022

docs: add v1p2beta1 samples to README (#255)

6888f98

This was referenced Nov 9, 2022

migrate code from googleapis/nodejs-video-intelligence #3507

Closed

migrate code from googleapis/nodejs-video-intelligence #3519

Merged

sofisl pushed a commit that referenced this pull request Nov 10, 2022

Update Translate samples, with some minor tweaks to Language samples. (…

8fe9517

…#255)

sofisl pushed a commit that referenced this pull request Nov 10, 2022

build: patch Windows container, fixing Node 10 (#255)

7b601e0

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-translate #3520

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 10, 2022

feat: add support for IAM policy options (#255)

d36a6e5

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-tasks #3530

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore(nodejs): remove api-extractor dependencies (#255)

6b1ddca

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-web-risk #3549

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: new owl bot post processor docker image (#255)

dc1c894

gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:f93bb861d6f12574437bb9aee426b71eafd63b419669ff0ed029f4b7e7162e3f

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-grafeas #3551

Merged

migrate code from googleapis/nodejs-secret-manager #3553

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix(deps): use google-gax v3.5.2 (#255)

153a834

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-billing #3556

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore(deps): update dependency @types/mocha to v7 (#255)

a2413eb

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-cloudbuild #3566

Merged

migrate code from googleapis/nodejs-asset #3567

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

feat: Implementation of Build Failure Info: - Added message FailureIn…

3c54ae6

…fo field (#255) PiperOrigin-RevId: 385847244 Source-Link: googleapis/googleapis@f84d1e2 Source-Link: googleapis/googleapis-gen@ff9cf56

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-talent #3568

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

samples: add Job Search v4 samples (#255)

51a5c21

release-please bot mentioned this pull request Nov 12, 2022

chore: release main #3529

Merged

sofisl pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency eslint-config-prettier to v4 (#255)

0b09628

sofisl mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-compute #3666

Merged

4 tasks

sofisl mentioned this pull request Nov 30, 2022

migrate code from googleapis/nodejs-datacatalog #3689

Merged

4 tasks

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

Release v0.11.0 (#255)

f80090b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

datastore: tests: refactor pb/transaction. #255

datastore: tests: refactor pb/transaction. #255

stephenplusplus commented Oct 10, 2014

This comment was marked as spam.

This comment was marked as spam.

ryanseys commented Oct 12, 2014

stephenplusplus commented Oct 12, 2014

ryanseys commented Oct 12, 2014

stephenplusplus commented Oct 12, 2014

stephenplusplus commented Oct 12, 2014

ryanseys commented Oct 12, 2014

stephenplusplus commented Oct 13, 2014

silvolu commented Oct 13, 2014

stephenplusplus commented Oct 13, 2014

silvolu commented Oct 13, 2014

ryanseys commented Oct 13, 2014

ryanseys commented Oct 13, 2014

datastore: tests: refactor pb/transaction. #255

datastore: tests: refactor pb/transaction. #255

Conversation

stephenplusplus commented Oct 10, 2014

This comment was marked as spam.

This comment was marked as spam.

ryanseys commented Oct 12, 2014

stephenplusplus commented Oct 12, 2014

ryanseys commented Oct 12, 2014

stephenplusplus commented Oct 12, 2014

stephenplusplus commented Oct 12, 2014

ryanseys commented Oct 12, 2014

stephenplusplus commented Oct 13, 2014

silvolu commented Oct 13, 2014

stephenplusplus commented Oct 13, 2014

silvolu commented Oct 13, 2014

ryanseys commented Oct 13, 2014

ryanseys commented Oct 13, 2014