Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastore: tests: refactor pb/transaction. #255

Merged
merged 3 commits into from
Oct 13, 2014

Conversation

stephenplusplus
Copy link
Contributor

This makes it so protobuf request encoding/response decoding and transactional/non-transactional properties are all handled in one place.


var pbKey = method[0].toUpperCase() + method.substr(1);
var pbRequest = new pb[pbKey + 'Request'](req).toBuffer();
var pbResponse = pb[pbKey + 'Response'];

This comment was marked as spam.

This comment was marked as spam.

@ryanseys
Copy link
Contributor

Overall looks really good. Just wondering why createRequest_ takes a req object? It's confusing that a method that creates requests needs a "request". :) Can we clarify that?

@stephenplusplus
Copy link
Contributor Author

You named it, bro :p. I was thinking that, too. How about makeReq like the
other places?

On Sunday, October 12, 2014, Ryan Seys notifications@github.com wrote:

Overall looks really good. Just wondering why createRequest_ takes a req
object? It's confusing that a method that creates requests needs a
"request". :) Can we clarify that?


Reply to this email directly or view it on GitHub
#255 (comment)
.

@ryanseys
Copy link
Contributor

I renamed it from makeReq_. Yes we can change it back if you'd like, but that still doesn't help explain why it takes a request object :P

@stephenplusplus
Copy link
Contributor Author

It's piping the request up to our "requester", adding headers along the
way. So, I guess the thought was make a request with this request object.
That was Burcu's design, just my interpretation ^

On Sunday, October 12, 2014, Ryan Seys notifications@github.com wrote:

I renamed it from makeReq_. Yes we can change it back if you'd like,
but that still doesn't help explain why it takes a request object :P


Reply to this email directly or view it on GitHub
#255 (comment)
.

@stephenplusplus
Copy link
Contributor Author

And our requester is called request, which takes the request from our
makeReq request.

Whoa.

On Sunday, October 12, 2014, Stephen Sawchuk sawchuk@gmail.com wrote:

It's piping the request up to our "requester", adding headers along the
way. So, I guess the thought was make a request with this request object.
That was Burcu's design, just my interpretation ^

On Sunday, October 12, 2014, Ryan Seys <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

I renamed it from makeReq_. Yes we can change it back if you'd like,
but that still doesn't help explain why it takes a request object :P


Reply to this email directly or view it on GitHub
#255 (comment)
.

@ryanseys
Copy link
Contributor

And if I recall correctly, we use the request library to send the requests ;)

@stephenplusplus
Copy link
Contributor Author

-createRequest_
+makeReq_

@silvolu
Copy link
Contributor

silvolu commented Oct 13, 2014

Maybe rename req to something like requestBody ?

@stephenplusplus
Copy link
Contributor Author

Renamed to body

@silvolu
Copy link
Contributor

silvolu commented Oct 13, 2014

@ryanseys any better?

@ryanseys
Copy link
Contributor

Yes, this is better!

@ryanseys
Copy link
Contributor

LGTM.

silvolu added a commit that referenced this pull request Oct 13, 2014
datastore: tests: refactor pb/transaction.
@silvolu silvolu merged commit 00e6466 into googleapis:master Oct 13, 2014
sofisl pushed a commit that referenced this pull request Sep 16, 2022
sofisl pushed a commit that referenced this pull request Sep 27, 2022
sofisl pushed a commit that referenced this pull request Nov 9, 2022
sofisl pushed a commit that referenced this pull request Nov 10, 2022
sofisl pushed a commit that referenced this pull request Nov 11, 2022
gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:f93bb861d6f12574437bb9aee426b71eafd63b419669ff0ed029f4b7e7162e3f
sofisl pushed a commit that referenced this pull request Nov 11, 2022
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^12.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/12.20.13/14.17.0) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/compatibility-slim/12.20.13)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/confidence-slim/12.20.13)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-secret-manager).
sofisl pushed a commit that referenced this pull request Nov 11, 2022
sofisl pushed a commit that referenced this pull request Nov 11, 2022
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@release-please release-please bot mentioned this pull request Nov 12, 2022
sofisl pushed a commit that referenced this pull request Nov 30, 2022
* chore: migrate to owl bot

* chore: copy files from googleapis-gen eebcfa346c9963da765cd71722c40e04dc3621dd

* chore: run the post processor

* 🦉 Updates from OwlBot

* chore: update post processor docker image

* 🦉 Updates from OwlBot

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants