Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update monitoring client #2526

Merged
merged 4 commits into from
Aug 16, 2017
Merged

Update monitoring client #2526

merged 4 commits into from
Aug 16, 2017

Conversation

evaogbe
Copy link
Contributor

@evaogbe evaogbe commented Aug 11, 2017

Closes #2486, closes #1801

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f4d2a83 on eoogbe:monitoring-updateclient into 118b622 on GoogleCloudPlatform:master.

@evaogbe evaogbe added the api: monitoring Issues related to the Cloud Monitoring API. label Aug 11, 2017
stephenplusplus
stephenplusplus reviewed Aug 11, 2017
View reviewed changes
packages/monitoring/package.json Outdated
"email": "sawchuk@gmail.com"
}
],
"version": "0.3.0",

This comment was marked as spam.

Sign in to view

packages/monitoring/package.json Outdated
},
"devDependencies": {
"mocha": "^3.1.2"
"mocha": "^3.2.0",
"through2": "^2.0.3"

This comment was marked as spam.

Sign in to view

packages/monitoring/src/v3/index.js Outdated
v3.SERVICE_ADDRESS = groupServiceClient.SERVICE_ADDRESS;
v3.ALL_SCOPES = groupServiceClient.ALL_SCOPES;
v3.ALL_SCOPES = union(

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cc8aecd on eoogbe:monitoring-updateclient into 118b622 on GoogleCloudPlatform:master.

stephenplusplus
stephenplusplus reviewed Aug 12, 2017
View reviewed changes
packages/monitoring/package.json Outdated
@@ -30,8 +30,7 @@
"lodash.union": "^4.6.0"

This comment was marked as spam.

Sign in to view

stephenplusplus
stephenplusplus reviewed Aug 12, 2017
View reviewed changes
packages/monitoring/src/index.js Outdated
* common application components including Cassandra, Nginx, Apache Web Server,
* Elasticsearch and many others. Stackdriver ingests that data and generates
* insights via dashboards, charts, and alerts.
* Create an groupServiceClient with additional helpers for common

This comment was marked as spam.

Sign in to view

packages/monitoring/src/index.js Outdated
}

/**
* Create an metricServiceClient with additional helpers for common

This comment was marked as spam.

Sign in to view

packages/monitoring/src/index.js
@@ -20,35 +20,91 @@

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus force-pushed the monitoring-updateclient branch from 0f94142 to 2b6bbd7 Compare August 16, 2017 12:53
@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 16, 2017
@googleapis googleapis deleted a comment from googlebot Aug 16, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2b6bbd7 on eoogbe:monitoring-updateclient into 36e7e41 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 16, 2017
@stephenplusplus stephenplusplus merged commit fdae234 into googleapis:master Aug 16, 2017
@evaogbe evaogbe deleted the monitoring-updateclient branch August 16, 2017 20:49
@bjwatson bjwatson mentioned this pull request Aug 17, 2017
Closed
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@evaogbe @stephenplusplus
Update monitoring client (#2526)
4a8b396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus left review comments

Assignees
No one assigned
Labels
api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing dummy docs JS files Remove references to auto-generated in Monitoring README
4 participants
@evaogbe @coveralls @stephenplusplus @googlebot