Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stackdriver info to readme #2335

Merged
merged 2 commits into from
May 31, 2017
Merged

add stackdriver info to readme #2335

merged 2 commits into from
May 31, 2017

Conversation

JustinBeckwith
Copy link
Contributor

We should be surfacing the Stackdriver npm modules at the same level as the others

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 26, 2017
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 26, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 70e89e7 on JustinBeckwith:master into 0ef2737 on GoogleCloudPlatform:master.

Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Added one nit.

README.md Outdated
- [GitHub Repo][stackdriver-debug-nodejs-repo]
- [Official Documentation][stackdriver-debug-docs]

*The source code for the Node.js Cloud Debugger Agent lives in a [separate repo][cloud-debug-nodejs-repo].*

This comment was marked as spam.

@JustinBeckwith
Copy link
Contributor Author

ping folks can we get this merged?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 827af94 on JustinBeckwith:master into 0ef2737 on GoogleCloudPlatform:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants