Fix pagination for queries with offset. #23

silvolu · 2014-07-20T23:44:16Z

Apply the offset only to the first page, to avoid losing results in the following pages.

lib/datastore/index.js

@@ -280,6 +280,7 @@ Transaction.prototype.runQuery = function(q, opt_callback) {
    var nextQuery = null;
    if (resp.batch.endCursor && resp.batch.endCursor != q.startVal) {
      nextQuery = q.start(resp.batch.endCursor);
+      nextQuery.offset(0);


silvolu · 2014-07-21T18:15:22Z

Done.

rakyll · 2014-07-21T18:17:14Z

LGTM.

Fix pagination for queries with offset.

* chore: lock files maintenance * chore: lock files maintenance

* chore: setup nighty build in CircleCI * chore: setup nighty build in CircleCI

For each client method returning a long running operation, a separate method to check its status is added. Added methods: `checkApplyParametersProgress`, `checkCreateInstanceProgress`, `checkDeleteInstanceProgress`, `checkUpdateInstanceProgress`, `checkUpdateParametersProgress`.

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/5f7bb900-b4ec-41d2-acea-c5c2f5dfb4fa/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@901ddd4 Source-Link: googleapis/synthtool@f96d3b4

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 392067151 Source-Link: googleapis/googleapis@06345f7 Source-Link: googleapis/googleapis-gen@95882b3

🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/nodejs-gke-connect-gateway/compare/v1.0.3...v1.1.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#23](https://www.github.com/googleapis/nodejs-gke-connect-gateway/issues/23)) ([4041bbd](https://www.github.com/googleapis/nodejs-gke-connect-gateway/commit/4041bbd7361a8aecfb86a886d0c7661db52c2e31)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [1.1.0](googleapis/nodejs-ids@v1.0.0...v1.1.0) (2022-03-23) ### Features * promote to stable ([#22](googleapis/nodejs-ids#22)) ([3ed2274](googleapis/nodejs-ids@3ed2274)), closes [#7](googleapis/nodejs-ids#7) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`^16.0.0` -> `^18.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/16.18.3/18.11.9) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/compatibility-slim/16.18.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/confidence-slim/16.18.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-bare-metal-solution).

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^9.2.1` -> `^10.0.0`](https://renovatebot.com/diffs/npm/sinon/9.2.4/10.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/compatibility-slim/9.2.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/confidence-slim/9.2.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v10.0.0`](https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#1000--2021-03-22) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v9.2.4...v10.0.0) ================== - Upgrade nise to 4.1.0 - Use [@sinonjs/eslint-config](https://togithub.com/sinonjs/eslint-config)[@4](https://togithub.com/4) => Adopts ES2017 => Drops support for IE 11, Legacy Edge and legacy Safari </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-network-connectivity).

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 468790263 Source-Link: googleapis/googleapis@873ab45 Source-Link: googleapis/googleapis-gen@cb6f37a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9

* generated GAPIC v2 code * lint and prettier * WIP: update samples * Upgrade samples + tests * Fix lint errors + add dateshiftconfig sample * Remove extraneous triggers field * Add descriptions to triggers + add missing result file * s/projectId/callingProject/ + remove project id from deleteJob * Add templateId + displayName to templates.js * Remove includeQuote + use dataProjectId * IMPORTANT: properly process multiple buckets * IMPORTANT: properly process multiple buckets, pt 2 * Minor tweaks to deid * Remove inspectconfig-specific print statements * (Almost-)final draft of Node.js DLP samples * Regenerate README * Fix nits * Move require statements to the top of functions * Nit: fix comment * Fix incorrect limit syntax in quickstart * Clarify that filter parameter is not entirely optional * Add missing README sections * Only ack pubsub messages with the desired contents * Update redact images * Missed a spot :( * regenerated v2 GAPIC code, fixed samples and system tests * get rid of unused response variables * unskipping some samples test that actually work * fixing bigquery tests * Finishing touches - add delay to DlpJob retrieval + make DlpJob tests parallel * prettier

fix: use google-gax v3.3.0 Source-Link: googleapis/synthtool@c73d112 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e

🤖 I have created a release *beep* *boop* --- ## [0.2.3](googleapis/nodejs-run@v0.2.2...v0.2.3) (2022-09-14) ### Bug Fixes * Allow passing gax instance to client constructor ([#24](googleapis/nodejs-run#24)) ([91e2ac5](googleapis/nodejs-run@91e2ac5)) * Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-run/issues/1553)) ([#23](googleapis/nodejs-run#23)) ([acda49f](googleapis/nodejs-run@acda49f)) * Preserve default values in x-goog-request-params header ([#26](googleapis/nodejs-run#26)) ([debc1eb](googleapis/nodejs-run@debc1eb)) * use google-gax v3.3.0 ([acda49f](googleapis/nodejs-run@acda49f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/cb56ba31-8af5-4a2d-bb02-4d94fe4706d8/targets - [ ] To automatically regenerate this PR, check this box. PiperOrigin-RevId: 345596855 Source-Link: googleapis/googleapis@d189e87

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`^16.0.0` -> `^18.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/16.18.3/18.11.9) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/compatibility-slim/16.18.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/confidence-slim/16.18.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-dataform).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`^16.0.0` -> `^18.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/16.18.3/18.11.9) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/compatibility-slim/16.18.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/confidence-slim/16.18.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-apigee-registry).

* 0.7.1

rakyll reviewed Jul 21, 2014
View reviewed changes

Query.start should set the offset to 0.

ad9626e

rakyll pushed a commit that referenced this pull request Jul 21, 2014

Merge pull request #23 from silvolu/master

ffcf2d2

Fix pagination for queries with offset.

rakyll merged commit ffcf2d2 into googleapis:master Jul 21, 2014

sofisl pushed a commit that referenced this pull request Sep 15, 2022

test: use strictEqual in tests (#23)

905d41c

This was referenced Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

migrate code from googleapis/nodejs-os-login #3366

Closed

sofisl pushed a commit that referenced this pull request Sep 16, 2022

chore: lock files maintenance (#23)

aba289c

* chore: lock files maintenance * chore: lock files maintenance

sofisl pushed a commit that referenced this pull request Sep 27, 2022

feat: generated GAPIC code for v1p1beta1 (#23)

9b8d098

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore: lock files maintenance (#23)

ccdc088

* chore: lock files maintenance * chore: lock files maintenance

This was referenced Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

migrate code from googleapis/nodejs-os-login #3389

Closed

sofisl pushed a commit that referenced this pull request Oct 8, 2022

chore: lock files maintenance (#23)

3f24c5e

* chore: lock files maintenance * chore: lock files maintenance

This was referenced Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

migrate code from googleapis/nodejs-bigquery-data-transfer #3399

Merged

sofisl pushed a commit that referenced this pull request Oct 12, 2022

chore: setup nighty build in CircleCI (#23)

035267b

* chore: setup nighty build in CircleCI * chore: setup nighty build in CircleCI

sofisl pushed a commit that referenced this pull request Oct 12, 2022

chore: one more workaround for repo-tools EPERM (#23)

6ca738c

sofisl mentioned this pull request Oct 12, 2022

migrate code from googleapis/nodejs-resource-manager #3402

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

chore: release 2.0.2 (#23)

a7baf5e

This was referenced Oct 13, 2022

migrate code from googleapis/nodejs-recommender #3409

Merged

migrate code from googleapis/nodejs-memcache #3412

Merged

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-bigquery-reservation #3413

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

feat: turns on self-signed JWT feature flag (#23)

eb70a17

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 392067151 Source-Link: googleapis/googleapis@06345f7 Source-Link: googleapis/googleapis-gen@95882b3

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-gke-connect-gateway #3416

Merged

4 tasks

sofisl mentioned this pull request Nov 12, 2022

migrate code from googleapis/nodejs-ids #3617

Merged

4 tasks

sofisl mentioned this pull request Nov 12, 2022

migrate code from googleapis/nodejs-bare-metal-solution #3618

Merged

4 tasks

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-network-connectivity #3643

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 16, 2022

build: updated kokoro config for coverage and release-please (#23)

8940548

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

4 tasks

sofisl mentioned this pull request Nov 30, 2022

migrate code from googleapis/nodejs-datacatalog #3689

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 30, 2022

chore: release 1.0.2 (#23)

dbb11e3

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

sofisl mentioned this pull request Dec 21, 2022

migrate code from googleapis/nodejs-video-stitcher #3811

Merged

4 tasks

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

This was referenced Jan 10, 2023

migrate code from googleapis/nodejs-run #3838

Merged

migrate code from googleapis/nodejs-vision #3860

Merged

sofisl pushed a commit that referenced this pull request Jan 17, 2023

chore(package): update eslint to version 4.15.0 (#23)

c7a6192

sofisl mentioned this pull request Jan 26, 2023

migrate code from googleapis/nodejs-ai-platform #3892

Merged

4 tasks

sofisl mentioned this pull request Feb 23, 2023

chore: migrate code from googleapis/nodejs-dataform #4015

Merged

4 tasks

This was referenced Sep 13, 2023

migrate code from googleapis/nodejs-apigee-registry #4654

Merged

migrate code from googleapis/nodejs-automl #4655

Closed

sofisl pushed a commit that referenced this pull request Sep 13, 2023

test: throw on deprecation (#23)

b6ee970

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

0.7.1 (#23)

c122f53

* 0.7.1

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix pagination for queries with offset. #23

Fix pagination for queries with offset. #23

silvolu commented Jul 20, 2014

This comment was marked as spam.

silvolu commented Jul 21, 2014

rakyll commented Jul 21, 2014

Fix pagination for queries with offset. #23

Fix pagination for queries with offset. #23

Conversation

silvolu commented Jul 20, 2014

This comment was marked as spam.

silvolu commented Jul 21, 2014

rakyll commented Jul 21, 2014