fix(connection): allow more connection callbacks #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node's default limit for max listeners on an event emitter is at a low 10. We are using an event emitter internally in the Connection class to handle queueing callbacks for the token retrieval event. The default of 10 is now lifted to unlimited, so the developer doesn't have to worry about overriding the default themselves. Fixes googleapis#223
rakyll
pushed a commit
that referenced
this pull request
Sep 20, 2014
fix(connection): allow more connection callbacks
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 16, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 8, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
refactor: use execSync for tests #225 automerged by dpebot
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
4 tasks
sofisl
added a commit
that referenced
this pull request
Oct 13, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^14.0.0` -> `^16.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/14.17.32/16.11.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-monitoring-dashboards).
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
refactor: use execSync for tests #225 automerged by dpebot
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
* docs(samples): Update ReadMe and comments for samples * docs(samples): Update ReadMe and comments for samples * Update bodyparser and comment * Fix merge error * Add comment for bodyParser * Update comment
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
#225) * build(node): add feat in node post-processor to add client library version number in snippet metadata Co-authored-by: Benjamin E. Coe <bencoe@google.com> Source-Link: googleapis/synthtool@d337b88 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:d106724ad2a96daa1b8d88de101ba50bdb30b8df62ffa0aa2b451d93b4556641
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/mocha](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/8.2.3/9.1.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-service-directory).
4 tasks
sofisl
added a commit
that referenced
this pull request
Nov 11, 2022
* build!: Update library to use Node 12 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
The library is regenerated with gapic-generator-typescript v1.3.1. Committer: @alexander-fenster PiperOrigin-RevId: 372468161 Source-Link: googleapis/googleapis@75880c3 Source-Link: googleapis/googleapis-gen@77b1804
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^14.0.0` -> `^16.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/14.17.32/16.11.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-game-servers).
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
* docs(samples): add example tags to generated samples PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: googleapis/googleapis-gen@eb888bc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## [2.1.1](https://togithub.com/googleapis/nodejs-retail/compare/v2.1.0...v2.1.1) (2022-11-16) ### Bug Fixes * **deps:** Use google-gax v3.5.2 ([#221](https://togithub.com/googleapis/nodejs-retail/issues/221)) ([5eb17fc](https://togithub.com/googleapis/nodejs-retail/commit/5eb17fc9c340cacbb8627442c58597015a2d4134)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
sofisl
pushed a commit
that referenced
this pull request
Nov 17, 2022
This was referenced Nov 17, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 18, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 30, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
fix(deps): update dependency @google-cloud/paginator to ^0.2.0 This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | @​google-cloud/paginator | dependencies | minor | [`^0.1.0` -> `^0.2.0`](https://diff.intrinsic.com/@google-cloud/paginator/0.1.2/0.2.0) | [source](https://togithub.com/googleapis/nodejs-paginator) | --- ### Release Notes <details> <summary>googleapis/nodejs-paginator</summary> ### [`v0.2.0`](https://togithub.com/googleapis/nodejs-paginator/blob/master/CHANGELOG.md#v020) [Compare Source](https://togithub.com/googleapis/nodejs-paginator/compare/v0.1.2...v0.2.0) 03-08-2019 12:15 PST ##### New Features - feat: handle promise based functions ([#​91](https://togithub.com/googleapis/nodejs-paginator/pull/91)) - refactor(ts): create generic for object streams ([#​101](https://togithub.com/googleapis/nodejs-paginator/pull/101)) ##### Dependencies - chore(deps): update dependency through2 to v3 ([#​53](https://togithub.com/googleapis/nodejs-paginator/pull/53)) - chore(deps): update dependency [@​types/is](https://togithub.com/types/is) to v0.0.21 ([#​55](https://togithub.com/googleapis/nodejs-paginator/pull/55)) - chore(deps): update dependency gts to ^0.9.0 ([#​57](https://togithub.com/googleapis/nodejs-paginator/pull/57)) - fix: Pin [@​types/sinon](https://togithub.com/types/sinon) to last compatible version ([#​61](https://togithub.com/googleapis/nodejs-paginator/pull/61)) - refactor: trim a few dependencies ([#​60](https://togithub.com/googleapis/nodejs-paginator/pull/60)) - chore(deps): update dependency [@​types/sinon](https://togithub.com/types/sinon) to v5.0.7 ([#​62](https://togithub.com/googleapis/nodejs-paginator/pull/62)) - chore(deps): update dependency [@​types/sinon](https://togithub.com/types/sinon) to v7 ([#​81](https://togithub.com/googleapis/nodejs-paginator/pull/81)) - chore(deps): update dependency mocha to v6 ##### Documentation - docs: add lint/fix example to contributing guide ([#​85](https://togithub.com/googleapis/nodejs-paginator/pull/85)) - chore: move CONTRIBUTING.md to root ([#​87](https://togithub.com/googleapis/nodejs-paginator/pull/87)) - docs: update links in contrib guide ([#​94](https://togithub.com/googleapis/nodejs-paginator/pull/94)) - docs: update contributing path in README ([#​88](https://togithub.com/googleapis/nodejs-paginator/pull/88)) ##### Internal / Testing Changes - chore: include build in eslintignore ([#​49](https://togithub.com/googleapis/nodejs-paginator/pull/49)) - chore: update CircleCI config ([#​52](https://togithub.com/googleapis/nodejs-paginator/pull/52)) - chore: use latest npm on Windows ([#​54](https://togithub.com/googleapis/nodejs-paginator/pull/54)) - chore: update eslintignore config ([#​56](https://togithub.com/googleapis/nodejs-paginator/pull/56)) - chore: add synth.metadata - fix(build): fix system key decryption ([#​64](https://togithub.com/googleapis/nodejs-paginator/pull/64)) - chore: update license file ([#​68](https://togithub.com/googleapis/nodejs-paginator/pull/68)) - chore(build): update prettier config ([#​69](https://togithub.com/googleapis/nodejs-paginator/pull/69)) - chore: nyc ignore build/test by default ([#​71](https://togithub.com/googleapis/nodejs-paginator/pull/71)) - chore: always nyc report before calling codecov ([#​72](https://togithub.com/googleapis/nodejs-paginator/pull/72)) - build: add Kokoro configs for autorelease ([#​75](https://togithub.com/googleapis/nodejs-paginator/pull/75)) - fix(build): fix Kokoro release script ([#​76](https://togithub.com/googleapis/nodejs-paginator/pull/76)) - chore: fix publish.sh permission +x ([#​77](https://togithub.com/googleapis/nodejs-paginator/pull/77)) - chore: update nyc and eslint configs ([#​79](https://togithub.com/googleapis/nodejs-paginator/pull/79)) - chore(build): inject yoshi automation key ([#​80](https://togithub.com/googleapis/nodejs-paginator/pull/80)) - build: check broken links in generated docs ([#​82](https://togithub.com/googleapis/nodejs-paginator/pull/82)) - build: ignore googleapis.com in doc link check ([#​84](https://togithub.com/googleapis/nodejs-paginator/pull/84)) - build: test using [@​grpc/grpc-js](https://togithub.com/grpc/grpc-js) in CI ([#​89](https://togithub.com/googleapis/nodejs-paginator/pull/89)) - build: create docs test npm scripts ([#​90](https://togithub.com/googleapis/nodejs-paginator/pull/90)) - build: use linkinator for docs test ([#​93](https://togithub.com/googleapis/nodejs-paginator/pull/93)) - build: update release configuration - build: fix types for sinon ([#​98](https://togithub.com/googleapis/nodejs-paginator/pull/98)) - build: use node10 to run samples-test, system-test etc ([#​97](https://togithub.com/googleapis/nodejs-paginator/pull/97)) - build: Add docuploader credentials to node publish jobs ([#​99](https://togithub.com/googleapis/nodejs-paginator/pull/99)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#googleapis/nodejs-dns). #225 automerged by dpebot
This was referenced Dec 14, 2023
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node's default limit for max listeners on an event emitter is at a low
10. We are using an event emitter internally in the Connection class to
handle queueing callbacks for the token retrieval event. The default of
10 is now lifted to unlimited, so the developer doesn't have to worry
about overriding the default themselves.
Fixes #223